Mercurial > evolve
annotate MANIFEST.in @ 1363:2eaa2943f9f3
directaccess: use cached filteredrevs
Before this patch we were calling directly repoview.computehidden(repo) to
compute the revisions visible with direct access, without going through the
caching mechanism for the filtered revisions.
There was two issues with that:
(1) Performance: We were not leverating the cached values of the 'visible' revs
(2) Stability: If there were to be a cache inconsistency with the computation of
'visible' we would crash in the branchmap consistency check partial.validfor.
Consider the scenario of rebase with bookmarks:
- when we delete a bookmark on an obsolete changeset (like what rebase
does when moving the bookmark after rebasing the changesets)
- then this changes the value returned by repoview.computehidden(repo) as
bookmarks are used as dynamic blockers in repoview.computehidden(repo)
- as of now, we don't invalidate the cache in the case of bookmark change
- if we have a cached value from before the bookmark change,
repoview.filterrevs(repo, 'visible') considers the cached value correct and
returns something different than repoview.computehidden(repo)
- in turn, if we use repoview.computehidden(repo) in directaccess, the subset
relationship is broken and the cache consistency assertion (parial.validfor)
fails if branchmap.updatecache is called in this time window
This patch leverages the caching infrastructure in place to speed up the
computation of the filteredrevs for visible-directaccess-nowarn and
visible-directaccess-warn. Incidentally it prevents the bug discussed in (2)
from crashing when running a rebase with a bookmark. Note that there still
needs to be a fix in core for the case discussed in (2).
The test for this side of the fix (not core's fix for (2) is very hard to
implement without introducing a lot of dependencies and does not belong
here. It is much easier to have the test of the fix for the scenario (2) in
core along with the fix.
author | Laurent Charignon <lcharignon@fb.com> |
---|---|
date | Sat, 13 Jun 2015 11:14:07 -0700 |
parents | 9cdd32b45bba |
children | be85d7ce8536 |
rev | line source |
---|---|
524
ba0a3d0f942f
pkg: add proper MANIFEST.in
Pierre-Yves David <pierre-yves.david@logilab.fr>
parents:
diff
changeset
|
1 recursive-include docs/figures *.svg |
ba0a3d0f942f
pkg: add proper MANIFEST.in
Pierre-Yves David <pierre-yves.david@logilab.fr>
parents:
diff
changeset
|
2 include docs/figures/hgview-example.png |
ba0a3d0f942f
pkg: add proper MANIFEST.in
Pierre-Yves David <pierre-yves.david@logilab.fr>
parents:
diff
changeset
|
3 include docs/*.rst |
ba0a3d0f942f
pkg: add proper MANIFEST.in
Pierre-Yves David <pierre-yves.david@logilab.fr>
parents:
diff
changeset
|
4 include docs/*.py |
ba0a3d0f942f
pkg: add proper MANIFEST.in
Pierre-Yves David <pierre-yves.david@logilab.fr>
parents:
diff
changeset
|
5 include docs/tutorials/*.t |
ba0a3d0f942f
pkg: add proper MANIFEST.in
Pierre-Yves David <pierre-yves.david@logilab.fr>
parents:
diff
changeset
|
6 include docs/makefile |
567
ea5d8b98ee54
update MANIFEST.in
Pierre-Yves David <pierre-yves.david@logilab.fr>
parents:
529
diff
changeset
|
7 include docs/static/*.svg |
524
ba0a3d0f942f
pkg: add proper MANIFEST.in
Pierre-Yves David <pierre-yves.david@logilab.fr>
parents:
diff
changeset
|
8 include hgext/__init__.py |
ba0a3d0f942f
pkg: add proper MANIFEST.in
Pierre-Yves David <pierre-yves.david@logilab.fr>
parents:
diff
changeset
|
9 include hgext/evolve.py |
733
d0472c630542
ship pushexperiment extension
Julien Cristau <julien.cristau@logilab.fr>
parents:
567
diff
changeset
|
10 include hgext/pushexperiment.py |
1062
9cdd32b45bba
pkg: make tests pass using the generated tarball
Faheem Mitha <faheem@faheem.info>
parents:
733
diff
changeset
|
11 include hgext/simple4server.py |
524
ba0a3d0f942f
pkg: add proper MANIFEST.in
Pierre-Yves David <pierre-yves.david@logilab.fr>
parents:
diff
changeset
|
12 include setup.py |
ba0a3d0f942f
pkg: add proper MANIFEST.in
Pierre-Yves David <pierre-yves.david@logilab.fr>
parents:
diff
changeset
|
13 include README |
ba0a3d0f942f
pkg: add proper MANIFEST.in
Pierre-Yves David <pierre-yves.david@logilab.fr>
parents:
diff
changeset
|
14 include COPYING |
ba0a3d0f942f
pkg: add proper MANIFEST.in
Pierre-Yves David <pierre-yves.david@logilab.fr>
parents:
diff
changeset
|
15 include tests/*.t |
ba0a3d0f942f
pkg: add proper MANIFEST.in
Pierre-Yves David <pierre-yves.david@logilab.fr>
parents:
diff
changeset
|
16 include tests/*.py |
1062
9cdd32b45bba
pkg: make tests pass using the generated tarball
Faheem Mitha <faheem@faheem.info>
parents:
733
diff
changeset
|
17 include tests/_exc-util.sh |
9cdd32b45bba
pkg: make tests pass using the generated tarball
Faheem Mitha <faheem@faheem.info>
parents:
733
diff
changeset
|
18 include tests/dummyssh |
529
365bf87ed4e8
pkg: exclude tests for unpackaged extension
Pierre-Yves David <pierre-yves.david@logilab.fr>
parents:
524
diff
changeset
|
19 exclude tests/test-oldconvert.t |
365bf87ed4e8
pkg: exclude tests for unpackaged extension
Pierre-Yves David <pierre-yves.david@logilab.fr>
parents:
524
diff
changeset
|
20 exclude tests/test-qsync.t |
1062
9cdd32b45bba
pkg: make tests pass using the generated tarball
Faheem Mitha <faheem@faheem.info>
parents:
733
diff
changeset
|
21 exclude tests/test-drop.t |