Mercurial > evolve
annotate MANIFEST.in @ 3846:f9dad99a90d5
evolve: create a new commit instead of amending one of the divergents
This patch changes the behavior of evolve command while resolving
content-divergence to create a new commit instead of amending one of the
divergent ones.
In past, I have made this change, backed out this change and now today again I
am doing this change, so let's dive in some history.
Using cmdrewrite.amend() was never a good option as that requires hack to delete
the evolvestate and also gives us less control over things. We can't make the
commit on top of different parents as that of content-divergent ones. Due to all
these, I first made this change to create a new commit instead of amending one.
But, after few days, there was flakiness observed in the tests and turned out
that we need to do some dirstate dance as repo.dirstate.setparents() does not
always fix the dirstate. That flakiness was a blocker for progress at that time
and we decided to switch to amend back so that we can have things working with
some hacks and we can later fix the implementation part.
Now, yesterday while tackling resolving content-divergence of a stack which is
as follows:
C1 C2
| |
B1 B2
| |
A1 A2
\/
base
where, A1-A2, B1-B2, C1-C2 are content-divergent with each other. Now we can
resolve A1-A2 very well because they have the same parent and let's say that
resolution leads to A3.
Now, we want to resolve B1-B2 and make the new resolution commit on top of A3 so
that we can end up something like:
C3
|
B3
|
A3
|
base
however, amending one of the divergent changesets, it's not possible to create a
commit on a different parent like A3 here without some relocation. We should
prevent relocation as that may leads to some conflicts and should change the
parent before committing.
So, looking ahead, we can't move with using amend as still using that we will
need some relocation hacks making code ugly and prone to bad behaviors, bugs.
Let's change back to creating a new commit so that we can move forward in a good
way.
About repo.dirstate.setparents() not setting the dirstate, I have researched
yesterday night about how we can do that and found out that we can use
cmdrewrite._uncommitdirstate() here. Expect upcoming patches to improve the
documentation of that function.
There are lot of test changes because of change in hash but there is no behavior
change. The only behavior change is in test-evolve-abort-contentdiv.t which is
nice because creating a new commit helps us in stripping that while aborting.
We have a lot of testing of content-divergence and no behavior change gives
enough confidence for making this change.
I reviewed the patch carefully to make sure there is no behavior change and I
suggest reviewer to do the same.
author | Pulkit Goyal <7895pulkit@gmail.com> |
---|---|
date | Wed, 13 Jun 2018 17:15:10 +0530 |
parents | b3dbba6e34c9 |
children | 48b30ff742cb |
rev | line source |
---|---|
2096
667cf3c020da
MANIFEST.in: fix various mismatch
Pierre-Yves David <pierre-yves.david@ens-lyon.org>
parents:
2078
diff
changeset
|
1 exclude contrib |
667cf3c020da
MANIFEST.in: fix various mismatch
Pierre-Yves David <pierre-yves.david@ens-lyon.org>
parents:
2078
diff
changeset
|
2 recursive-exclude contrib * |
667cf3c020da
MANIFEST.in: fix various mismatch
Pierre-Yves David <pierre-yves.david@ens-lyon.org>
parents:
2078
diff
changeset
|
3 exclude hgext3rd/evolve/hack |
667cf3c020da
MANIFEST.in: fix various mismatch
Pierre-Yves David <pierre-yves.david@ens-lyon.org>
parents:
2078
diff
changeset
|
4 recursive-exclude hgext3rd/evolve/hack * |
1810
ce4018f03520
hgext3rd: move 'obsolete' as 'evolve.legacy'
Pierre-Yves David <pierre-yves.david@ens-lyon.org>
parents:
1809
diff
changeset
|
5 exclude hgext3rd/evolve/legacy.py |
1774
23ea1f4d4040
Manifest.in: exclude debian related file
Pierre-Yves David <pierre-yves.david@ens-lyon.org>
parents:
1773
diff
changeset
|
6 exclude Makefile |
1770
be85d7ce8536
Manifest.in: sort entry
Pierre-Yves David <pierre-yves.david@ens-lyon.org>
parents:
1062
diff
changeset
|
7 exclude tests/test-drop.t |
1776
cb2bac3253fb
Manifest.in: exclude unshipped extensions
Pierre-Yves David <pierre-yves.david@ens-lyon.org>
parents:
1775
diff
changeset
|
8 exclude tests/test-inhibit.t |
1770
be85d7ce8536
Manifest.in: sort entry
Pierre-Yves David <pierre-yves.david@ens-lyon.org>
parents:
1062
diff
changeset
|
9 exclude tests/test-oldconvert.t |
3383
733e01473ec2
packaging: update MANIFEST.in to include new tutorial files
Boris Feld <boris.feld@octobus.net>
parents:
3033
diff
changeset
|
10 exclude docs/tutorial/.netlify |
1770
be85d7ce8536
Manifest.in: sort entry
Pierre-Yves David <pierre-yves.david@ens-lyon.org>
parents:
1062
diff
changeset
|
11 include COPYING |
524
ba0a3d0f942f
pkg: add proper MANIFEST.in
Pierre-Yves David <pierre-yves.david@logilab.fr>
parents:
diff
changeset
|
12 include docs/figures/hgview-example.png |
1770
be85d7ce8536
Manifest.in: sort entry
Pierre-Yves David <pierre-yves.david@ens-lyon.org>
parents:
1062
diff
changeset
|
13 include docs/makefile |
be85d7ce8536
Manifest.in: sort entry
Pierre-Yves David <pierre-yves.david@ens-lyon.org>
parents:
1062
diff
changeset
|
14 include docs/*.py |
be85d7ce8536
Manifest.in: sort entry
Pierre-Yves David <pierre-yves.david@ens-lyon.org>
parents:
1062
diff
changeset
|
15 include docs/README |
524
ba0a3d0f942f
pkg: add proper MANIFEST.in
Pierre-Yves David <pierre-yves.david@logilab.fr>
parents:
diff
changeset
|
16 include docs/*.rst |
1770
be85d7ce8536
Manifest.in: sort entry
Pierre-Yves David <pierre-yves.david@ens-lyon.org>
parents:
1062
diff
changeset
|
17 include docs/static/*.svg |
524
ba0a3d0f942f
pkg: add proper MANIFEST.in
Pierre-Yves David <pierre-yves.david@logilab.fr>
parents:
diff
changeset
|
18 include docs/tutorials/*.t |
1806
9f42f819267b
evolve: move the extensions to 'hgext3rd'
Pierre-Yves David <pierre-yves.david@ens-lyon.org>
parents:
1805
diff
changeset
|
19 include hgext3rd/__init__.py |
2077
95f37f9a9064
MANIFEST.in: fix to include all evolve submodule
Pierre-Yves David <pierre-yves.david@ens-lyon.org>
parents:
1811
diff
changeset
|
20 include hgext3rd/evolve/*.py |
3390
b3dbba6e34c9
evolve: start vendoring third party package cbor
Pulkit Goyal <7895pulkit@gmail.com>
parents:
3383
diff
changeset
|
21 include hgext3rd/evolve/thirdparty/*.py |
2078
890af168ca31
MANIFEST.in: also includes topic
Pierre-Yves David <pierre-yves.david@ens-lyon.org>
parents:
2077
diff
changeset
|
22 include hgext3rd/topic/*.py |
3033
13751fef5e66
topics: move README-topic as hgext3rd/topic/README
Pulkit Goyal <7895pulkit@gmail.com>
parents:
3032
diff
changeset
|
23 include hgext3rd/topic/README |
1775
a37ef09e27b1
Manifest.in: include Manifest.in
Pierre-Yves David <pierre-yves.david@ens-lyon.org>
parents:
1774
diff
changeset
|
24 include MANIFEST.in |
1770
be85d7ce8536
Manifest.in: sort entry
Pierre-Yves David <pierre-yves.david@ens-lyon.org>
parents:
1062
diff
changeset
|
25 include README |
3032
ba5b271298e9
README: move CHANGELOG to a new file
Pulkit Goyal <7895pulkit@gmail.com>
parents:
2099
diff
changeset
|
26 include CHANGELOG |
524
ba0a3d0f942f
pkg: add proper MANIFEST.in
Pierre-Yves David <pierre-yves.david@logilab.fr>
parents:
diff
changeset
|
27 include setup.py |
ba0a3d0f942f
pkg: add proper MANIFEST.in
Pierre-Yves David <pierre-yves.david@logilab.fr>
parents:
diff
changeset
|
28 include tests/*.py |
1773
28745dc48ba0
Manifest.in: include all script in tests
Pierre-Yves David <pierre-yves.david@ens-lyon.org>
parents:
1772
diff
changeset
|
29 include tests/*.sh |
2096
667cf3c020da
MANIFEST.in: fix various mismatch
Pierre-Yves David <pierre-yves.david@ens-lyon.org>
parents:
2078
diff
changeset
|
30 include tests/testlib/*.sh |
1770
be85d7ce8536
Manifest.in: sort entry
Pierre-Yves David <pierre-yves.david@ens-lyon.org>
parents:
1062
diff
changeset
|
31 include tests/*.t |
3383
733e01473ec2
packaging: update MANIFEST.in to include new tutorial files
Boris Feld <boris.feld@octobus.net>
parents:
3033
diff
changeset
|
32 recursive-include docs/tutorial *.rst |
733e01473ec2
packaging: update MANIFEST.in to include new tutorial files
Boris Feld <boris.feld@octobus.net>
parents:
3033
diff
changeset
|
33 recursive-include docs/tutorial *.css |
733e01473ec2
packaging: update MANIFEST.in to include new tutorial files
Boris Feld <boris.feld@octobus.net>
parents:
3033
diff
changeset
|
34 include docs/tutorial/standalone.html |
733e01473ec2
packaging: update MANIFEST.in to include new tutorial files
Boris Feld <boris.feld@octobus.net>
parents:
3033
diff
changeset
|
35 recursive-include docs/tutorial *.js |
733e01473ec2
packaging: update MANIFEST.in to include new tutorial files
Boris Feld <boris.feld@octobus.net>
parents:
3033
diff
changeset
|
36 recursive-include docs/tutorial *.md |
733e01473ec2
packaging: update MANIFEST.in to include new tutorial files
Boris Feld <boris.feld@octobus.net>
parents:
3033
diff
changeset
|
37 recursive-include docs/tutorial *.py |
733e01473ec2
packaging: update MANIFEST.in to include new tutorial files
Boris Feld <boris.feld@octobus.net>
parents:
3033
diff
changeset
|
38 recursive-include docs/tutorial *.sh |
733e01473ec2
packaging: update MANIFEST.in to include new tutorial files
Boris Feld <boris.feld@octobus.net>
parents:
3033
diff
changeset
|
39 recursive-include docs/tutorial *.t |
1774
23ea1f4d4040
Manifest.in: exclude debian related file
Pierre-Yves David <pierre-yves.david@ens-lyon.org>
parents:
1773
diff
changeset
|
40 prune debian |
1770
be85d7ce8536
Manifest.in: sort entry
Pierre-Yves David <pierre-yves.david@ens-lyon.org>
parents:
1062
diff
changeset
|
41 recursive-include docs/figures *.svg |