comparison setup.cfg @ 3452:8275ef099135 stable

amend: query the wdir parent after taking lock (issue5266) If we query wdir parent without taking a lock, that can lead to bugs because the wdir parent can change is another process has changed the wdir parent. One such example of this was issue 5266. When a user is running amend and that amend is waiting for commit message, the user runs another amend which waits for lock. The second amend is waiting for lock, but has already read the description from the parent of working directory to use. Once the first amend completes the wdir parent changes but we still have the description from an old wdir parent. This patch fixes the bug by querying the description after taking lock. Attempts were made to add test for this but the results were unstable because they depend on time in which lock is released.
author Pulkit Goyal <7895pulkit@gmail.com>
date Mon, 22 Jan 2018 14:10:59 +0530
parents b81d3775006b
children
comparison
equal deleted inserted replaced
3451:f062a4719e46 3452:8275ef099135