Mercurial > evolve
diff CHANGELOG @ 6023:6c67219ce779 stable
topic: don't cache topic of e.g. memctx in _topiccache (issue6500)
_topiccache exists to make us hit the storage less often when we want to look
at topics for any reason. It doesn't make much sense to cache something that is
memory-only and is cheap to access however. Caching things like that was also a
source of a bug where creating multiple memctx instances in one process would
cache topic of the first one and ignore actual content of .extra() of the
others. That was happening because the cache is keyed by .rev(), but all memctx
instances have the same .rev() = None.
author | Anton Shestakov <av6@dwimlabs.net> |
---|---|
date | Sun, 29 Aug 2021 14:41:23 +0300 |
parents | bcdccdd48d99 |
children | bec2d792ceae |
line wrap: on
line diff
--- a/CHANGELOG Sun Aug 29 14:30:37 2021 +0300 +++ b/CHANGELOG Sun Aug 29 14:41:23 2021 +0300 @@ -4,6 +4,11 @@ 10.3.4 - in progress -------------------- +topic (0.22.4) + + * topic: don't cache .topic() of memctx instances, as that could produce + KeyError: b'topic' during some rewrite operations (issue6500) + 10.3.3 -- 2021-08-13 --------------------