Mercurial > evolve
diff CHANGELOG @ 5375:bed4fc158fc9
topic: treat argument to --topic as a literal topic name explicitly
We already do treat it as a string (i.e. not a special revset language symbol)
that needs to be escaped, because we use %s in repo.revs(), which escapes and
single-quotes the appropriate argument. But now we abort in case user supplies
topic name that doesn't exist.
Before this patch, when user ran something like `hg push --topic .`, this code
would use 'topic(".") - obsolete()' revset, which would get an empty set from
repo.revs() unless there was a topic named "." (unlikely, because this name is
reserved). This code would then add an empty set to the 'rev' argument of the
original hg push command. And `hg push` without -r will try and push
everything, and not just changesets on a specific topic.
author | Anton Shestakov <av6@dwimlabs.net> |
---|---|
date | Thu, 11 Jun 2020 18:50:29 +0800 |
parents | 028e4ea75456 |
children | 60317988f5ae |
line wrap: on
line diff
--- a/CHANGELOG Thu Jun 11 17:58:04 2020 +0800 +++ b/CHANGELOG Thu Jun 11 18:50:29 2020 +0800 @@ -7,6 +7,8 @@ topic (0.20.0) * stack: support foo#stack relation revset (hg-5.4+ only) + * topic: hg push --topic does-not-exist now doesn't try to push unrelated + changesets and aborts instead 10.0.0 -- 2020-05-09 --------------------