Mercurial > evolve
view setup.py @ 1593:2f117c299325
evolve: remove meaningless transaction nesting
Before this patch, functions below nest transaction scope, even though
they are invoked only inside a transaction scope created at _solveone().
- _solvebumped()
- _solvedivergent()
- relocate() via _solveunstable() or _solvebumped()
Transaction nesting is useful for localizing "success" (e.g. one scope
per commit inside wider scope for multiple committing).
But such nesting is redundant for _solveone(), because there is no
code path, which causes failure after successfully closing inner
transaction(s).
In addition to it, this nesting makes it complicated to close current
transaction successfully with exception raising inside inner scope,
like "hg shelve" at detection of conflicts. "tr.close()" is required
at each outer scopes for such case.
To remove meaningless transaction nesting, this patch replaces
repo.transaction() in functions above by repo.currenttransaction().
This reuses transaction created at _solveone().
This patch also adds 'assert tr' after getting current running
transaction, to avoid invocation of functions above without
transaction.
author | FUJIWARA Katsunori <foozy@lares.dti.ne.jp> |
---|---|
date | Sat, 23 Jan 2016 06:18:01 +0900 |
parents | 1bcbd14cf159 |
children | 160968654581 |
line wrap: on
line source
# Copied from histedit setup.py # Credit to Augie Fackler <durin42@gmail.com> import os from distutils.core import setup from os.path import dirname, join def get_version(relpath): '''Read version info from a file without importing it''' for line in open(join(dirname(__file__), relpath), 'rb'): # Decode to a fail-safe string for PY3 # (gives unicode object in PY2) line = line.decode('utf8') if '__version__' in line: if "'" in line: return line.split("'")[1] py_modules = [ 'hgext.evolve', ] if os.environ.get('INCLUDE_INHIBIT'): py_modules.append('hgext.inhibit') py_modules.append('hgext.directaccess') setup( name='hg-evolve', version=get_version('hgext/evolve.py'), author='Pierre-Yves David', maintainer='Pierre-Yves David', maintainer_email='pierre-yves.david@ens-lyon.org', url='https://bitbucket.org/marmoute/mutable-history', description='Flexible evolution of Mercurial history.', long_description=open('README').read(), keywords='hg mercurial', license='GPLv2+', py_modules=py_modules )