view debian/docs @ 973:6d691fefdbd1 stable

evolve: fix createmarkers() wrapper to accept an iterable

Docstring in mercurial.obsolete says "<relations> must be an iterable
of ...", and hgsubversion takes it at its word and passes a generator.
Until around Mercurial 3.0, this did not cause any problems, but now
it does: in a repo with both evolve and hgsubversion enabled, pushing
to Subversion when obsolete changesets are present causes a crash:

  [...]
  File "/home/gward/src/hgsubversion/hgsubversion/wrappers.py", line 346, in push
    obsolete.createmarkers(repo, relations)
  File "/home/gward/src/hg-stable/mercurial/extensions.py", line 196, in wrap
    return wrapper(origfn, *args, **kwargs)
  File "/home/gward/src/hg-evolve/hgext/evolve.py", line 332, in _createmarkers
    relations[idx] = (prec, sucs, meta)
TypeError: 'generator' object does not support item assignment

Since hgsubersion is playing by the documented rules, evolve must be
the guilty party here.

html