view contrib/nopushpublish.py @ 5507:95478db35f88 stable

topic: fix the `topic(...)` revset to not select commits without a topic

The problem seems to be that the now removed __contains__ check would select any
revision indicated by a non-string argument.  This led to `topic(head())`
returning a bunch of non-topic heads, though not as many as simply `head()`.

I'm likely misunderstanding something, because there appears to be a similar
__contains__ check for `branch()` in core.  But maybe that's just harder to see
the issue, because branch names doesn't disappear like topics.

# Extension which prevent changeset to be turn public by push operation
#
# Copyright 2011 Logilab SA        <[e-mail]>
#
# This software may be used and distributed according to the terms of the
# GNU General Public License version 2 or any later version.


from mercurial import extensions, util
from mercurial import discovery

def checkpublish(orig, repo, remote, outgoing, *args):

    # is remote publishing?
    publish = True
    if 'phases' in remote.listkeys('namespaces'):
        remotephases = remote.listkeys('phases')
        publish = remotephases.get('publishing', False)

    npublish = 0
    if publish:
        for rev in outgoing.missing:
            if repo[rev].phase():
                npublish += 1
    if npublish:
        repo.ui.warn("Push would publish %s changesets" % npublish)

    ret = orig(repo, remote, outgoing, *args)
    if npublish:
        raise util.Abort("Publishing push forbidden",
                         hint="Use `hg phase -p <rev>` to manually publish them")

    return ret

def uisetup(ui):
    extensions.wrapfunction(discovery, 'checkheads', checkpublish)