Mercurial > evolve
view .hgignore @ 6665:d2b90c9e5829 stable
uncommit: set uncommit_source extra consistently in interactive mode
Previously, the uncommit_source extra was only explicitly set on the temporary
changeset created during the uncommit command.
Due to a contract mismatch because the extra() method returned a dict that
might be reused for multiple callers and this call site expected a fresh dict,
the resulting changeset produced by the uncommit command might or might not
have had the correct extra nonetheless. This changeset ensures that it will be
set consistently.
There is a discussion whether the extra() method (in core) should always return
a fresh dict. Independent of the outcome of the discussion, this fix should
work. I checked that the tests work no matter whether extra() returns a fresh
dict or a reused one (current core behavior).
author | Manuel Jacob <me@manueljacob.de> |
---|---|
date | Thu, 01 Feb 2024 19:13:24 +0100 |
parents | ba316ce15040 |
children |
line wrap: on
line source
syntax: glob *.py[cdo] *~ *.swp *.orig *.rej *.egg-info syntax: rootglob .idea/ .mypy_cache/ .pytype/ .vscode/ html/ build/ dist/ MANIFEST tests/easy_run.sh tests/*.err tests/.testtimes* docs/training/graphs/ docs/training/html/ docs/training/index.html docs/training/graphviz-images/ docs/training/img/ docs/training/output/ docs/training/pandocfilters/ docs/tutorials/**.rst docs/figures/**.png docs/static/**.ico