# HG changeset patch # User Anton Shestakov # Date 1630645318 -10800 # Node ID 182e2a1dbd1c822d42febcb4cc4f2b4a29ced36d # Parent 2800aa3c3dbf6dfbcc0fb948fd54f12c3c5b4868 topic: drop topicfilter usage from topicrepo.commitctx() This block of code was introduced in 13313d0cab71, but the commit description doesn't explain the exact intent of this code. The fact that the result of other.commitctx() was discarded makes me think that this block only existed to deal with amends, and it was only useful for code that was removed earlier in this series. The only code that's left in commitctx() is adding current topic to workingcommitctx, and I don't think we need to adjust repo filter for that. diff -r 2800aa3c3dbf -r 182e2a1dbd1c hgext3rd/topic/__init__.py --- a/hgext3rd/topic/__init__.py Mon Aug 30 12:05:14 2021 +0300 +++ b/hgext3rd/topic/__init__.py Fri Sep 03 08:01:58 2021 +0300 @@ -484,11 +484,6 @@ return super(topicrepo, self).commit(*args, **kwargs) def commitctx(self, ctx, *args, **kwargs): - topicfilter = topicmap.topicfilter(self.filtername) - if topicfilter != self.filtername: - other = self.filtered(topicmap.topicfilter(self.filtername)) - other.commitctx(ctx, *args, **kwargs) - if isinstance(ctx, context.workingcommitctx): current = self.currenttopic if current: