# HG changeset patch # User Pierre-Yves David # Date 1512476517 -3600 # Node ID 5dfe4e5cf9e4790692feda0beeec113217a39092 # Parent df8d535216afe3de5f282e558f7b8e16564ac285 topic: use more protective code to access publishing code There are some code path where the operation is not properly initialized and lack the new attributes. While the lack of initialization, is suspicious and I've not be able to pin point case where this happens. Currently the code crash when it encounter this situation. So we make the code more resistant to this case to prevent bad user experience. diff -r df8d535216af -r 5dfe4e5cf9e4 hgext3rd/topic/flow.py --- a/hgext3rd/topic/flow.py Thu Nov 30 21:31:14 2017 -0800 +++ b/hgext3rd/topic/flow.py Tue Dec 05 13:21:57 2017 +0100 @@ -48,7 +48,7 @@ def wrapphasediscovery(orig, pushop): orig(pushop) - if pushop.publish: + if getattr(pushop, 'publish', False): if not util.safehasattr(pushop, 'remotephases'): msg = _('--publish flag only supported from Mercurial 4.4 and higher') raise error.Abort(msg)