changeset 5362:398c7031177a stable

tests: use hghaveaddon.py to check for flake8 Since we need flake8 to be a python module, we shouldn't use a shell script with `which` to check for its presence anymore.
author Anton Shestakov <av6@dwimlabs.net>
date Sun, 24 May 2020 13:20:45 +0800
parents 3987ce7e9824
children 9a1c3a6af656
files tests/hghaveaddon.py tests/test-check-flake8.t
diffstat 2 files changed, 12 insertions(+), 9 deletions(-) [+]
line wrap: on
line diff
--- a/tests/hghaveaddon.py	Sun May 24 13:07:44 2020 +0800
+++ b/tests/hghaveaddon.py	Sun May 24 13:20:45 2020 +0800
@@ -12,3 +12,14 @@
         except ImportError:
             return False
     return True
+
+@hghave.check("flake8", "Flake8 python linter")
+def has_flake8():
+    try:
+        import flake8
+
+        flake8.__version__
+    except ImportError:
+        return False
+    else:
+        return True
--- a/tests/test-check-flake8.t	Sun May 24 13:07:44 2020 +0800
+++ b/tests/test-check-flake8.t	Sun May 24 13:20:45 2020 +0800
@@ -1,12 +1,4 @@
-#require test-repo
-
-  $ checkflake8() {
-  >   if ! (which flake8 > /dev/null); then
-  >     echo skipped: missing tool: flake8;
-  >     exit 80;
-  >   fi;
-  > };
-  $ checkflake8
+#require test-repo flake8
 
 Copied from Mercurial core (60ee2593a270)