tests/test-check-shbang.t
author Gregory Szorc <gregory.szorc@gmail.com>
Wed, 03 Oct 2018 09:43:01 -0700
changeset 40031 62160d3077cd
parent 33204 ddd65b4f3ae6
child 43732 2d8d4e08c493
permissions -rw-r--r--
cborutil: change buffering strategy Profiling revealed that we were spending a lot of time on the line that was concatenating the old buffer with the incoming data when attempting to decode long byte strings, such as manifest revisions. Essentially, we were feeding N chunks of size len(X) << len(Y) into decode() and continuously allocating a new, larger buffer to hold the undecoded input. This created substantial memory churn and slowed down execution. Changing the code to aggregate pending chunks in a list until we have enough data to fully decode the next atom makes things much more efficient. I don't have exact data, but I recall the old code spending >1s on manifest fulltexts from the mozilla-unified repo. The new code doesn't significantly appear in profile output. Differential Revision: https://phab.mercurial-scm.org/D4854
Ignore whitespace changes - Everywhere: Within whitespace: At end of lines:
28879
8c1759a2bdf4 tests: add new test for #! shebang lines
timeless <timeless@mozdev.org>
parents: 27569
diff changeset
     1
#require test-repo
27569
b3eba79b7e04 tests: add test-check-execute.t
timeless <timeless@mozdev.org>
parents:
diff changeset
     2
29219
3c9066ed557c tests: silence test-repo obsolete warning
timeless <timeless@mozdev.org>
parents: 28879
diff changeset
     3
  $ . "$TESTDIR/helpers-testrepo.sh"
27569
b3eba79b7e04 tests: add test-check-execute.t
timeless <timeless@mozdev.org>
parents:
diff changeset
     4
  $ cd "`dirname "$TESTDIR"`"
b3eba79b7e04 tests: add test-check-execute.t
timeless <timeless@mozdev.org>
parents:
diff changeset
     5
28879
8c1759a2bdf4 tests: add new test for #! shebang lines
timeless <timeless@mozdev.org>
parents: 27569
diff changeset
     6
look for python scripts that do not use /usr/bin/env
27569
b3eba79b7e04 tests: add test-check-execute.t
timeless <timeless@mozdev.org>
parents:
diff changeset
     7
33204
ddd65b4f3ae6 tests: alias syshg and syshgenv so they can be switched conditionally
Yuya Nishihara <yuya@tcha.org>
parents: 33128
diff changeset
     8
  $ testrepohg files 'set:grep(r"^#!.*?python") and not grep(r"^#!/usr/bi{1}n/env python") - **/*.t'
27569
b3eba79b7e04 tests: add test-check-execute.t
timeless <timeless@mozdev.org>
parents:
diff changeset
     9
  [1]
b3eba79b7e04 tests: add test-check-execute.t
timeless <timeless@mozdev.org>
parents:
diff changeset
    10
32957
cad62cb3c84c tests: enforce use of $PYTHON in tests
Augie Fackler <augie@google.com>
parents: 29515
diff changeset
    11
In tests, enforce $PYTHON and *not* /usr/bin/env python or similar:
33204
ddd65b4f3ae6 tests: alias syshg and syshgenv so they can be switched conditionally
Yuya Nishihara <yuya@tcha.org>
parents: 33128
diff changeset
    12
  $ testrepohg files 'set:grep(r"#!.*?python") and **/*.t' \
32957
cad62cb3c84c tests: enforce use of $PYTHON in tests
Augie Fackler <augie@google.com>
parents: 29515
diff changeset
    13
  > -X tests/test-check-execute.t \
cad62cb3c84c tests: enforce use of $PYTHON in tests
Augie Fackler <augie@google.com>
parents: 29515
diff changeset
    14
  > -X tests/test-check-module-imports.t \
cad62cb3c84c tests: enforce use of $PYTHON in tests
Augie Fackler <augie@google.com>
parents: 29515
diff changeset
    15
  > -X tests/test-check-pyflakes.t \
cad62cb3c84c tests: enforce use of $PYTHON in tests
Augie Fackler <augie@google.com>
parents: 29515
diff changeset
    16
  > -X tests/test-check-shbang.t
cad62cb3c84c tests: enforce use of $PYTHON in tests
Augie Fackler <augie@google.com>
parents: 29515
diff changeset
    17
  [1]
cad62cb3c84c tests: enforce use of $PYTHON in tests
Augie Fackler <augie@google.com>
parents: 29515
diff changeset
    18
cad62cb3c84c tests: enforce use of $PYTHON in tests
Augie Fackler <augie@google.com>
parents: 29515
diff changeset
    19
The above exclusions are because they're looking for files that
cad62cb3c84c tests: enforce use of $PYTHON in tests
Augie Fackler <augie@google.com>
parents: 29515
diff changeset
    20
contain Python but don't end in .py - please avoid adding more.
cad62cb3c84c tests: enforce use of $PYTHON in tests
Augie Fackler <augie@google.com>
parents: 29515
diff changeset
    21
28879
8c1759a2bdf4 tests: add new test for #! shebang lines
timeless <timeless@mozdev.org>
parents: 27569
diff changeset
    22
look for shell scripts that do not use /bin/sh
27569
b3eba79b7e04 tests: add test-check-execute.t
timeless <timeless@mozdev.org>
parents:
diff changeset
    23
33204
ddd65b4f3ae6 tests: alias syshg and syshgenv so they can be switched conditionally
Yuya Nishihara <yuya@tcha.org>
parents: 33128
diff changeset
    24
  $ testrepohg files 'set:grep(r"^#!.*/bi{1}n/sh") and not grep(r"^#!/bi{1}n/sh")'
27569
b3eba79b7e04 tests: add test-check-execute.t
timeless <timeless@mozdev.org>
parents:
diff changeset
    25
  [1]