tests/test-check-pylint.t
author Martin von Zweigbergk <martinvonz@google.com>
Fri, 24 Aug 2018 08:45:18 -0700
changeset 39318 9f097214fbf3
parent 37853 6ae62d62c3f6
child 46073 c7899dd29800
permissions -rw-r--r--
index: embed nodetree in index object to avoid reference cycle Since the index has a reference to a nodetree and the nodetree has a reference back to the index, there is a reference cycle, so the index (and its nodetree) can never be freed. This patch fixes that by making "nodetree" a plan C struct that the index can embed, and also introduces a new "nodetreeObject" that is a Python type wrapping the nodetree struct. Thanks to Yuya for noticing this and for suggesting the solution. All tests passed on the first attempt once it compiled (I guess C is like Haskell in this regard?). Differential Revision: https://phab.mercurial-scm.org/D4372
Ignore whitespace changes - Everywhere: Within whitespace: At end of lines:
31422
aa797bd54f44 test: add a basic 'test-check-pylint.t'
Pierre-Yves David <pierre-yves.david@ens-lyon.org>
parents:
diff changeset
     1
#require test-repo pylint hg10
aa797bd54f44 test: add a basic 'test-check-pylint.t'
Pierre-Yves David <pierre-yves.david@ens-lyon.org>
parents:
diff changeset
     2
aa797bd54f44 test: add a basic 'test-check-pylint.t'
Pierre-Yves David <pierre-yves.david@ens-lyon.org>
parents:
diff changeset
     3
Run pylint for known rules we care about.
aa797bd54f44 test: add a basic 'test-check-pylint.t'
Pierre-Yves David <pierre-yves.david@ens-lyon.org>
parents:
diff changeset
     4
-----------------------------------------
aa797bd54f44 test: add a basic 'test-check-pylint.t'
Pierre-Yves David <pierre-yves.david@ens-lyon.org>
parents:
diff changeset
     5
aa797bd54f44 test: add a basic 'test-check-pylint.t'
Pierre-Yves David <pierre-yves.david@ens-lyon.org>
parents:
diff changeset
     6
There should be no recorded failures; fix the codebase before introducing a
aa797bd54f44 test: add a basic 'test-check-pylint.t'
Pierre-Yves David <pierre-yves.david@ens-lyon.org>
parents:
diff changeset
     7
new check.
aa797bd54f44 test: add a basic 'test-check-pylint.t'
Pierre-Yves David <pierre-yves.david@ens-lyon.org>
parents:
diff changeset
     8
aa797bd54f44 test: add a basic 'test-check-pylint.t'
Pierre-Yves David <pierre-yves.david@ens-lyon.org>
parents:
diff changeset
     9
Current checks:
aa797bd54f44 test: add a basic 'test-check-pylint.t'
Pierre-Yves David <pierre-yves.david@ens-lyon.org>
parents:
diff changeset
    10
- W0102: no mutable default argument
aa797bd54f44 test: add a basic 'test-check-pylint.t'
Pierre-Yves David <pierre-yves.david@ens-lyon.org>
parents:
diff changeset
    11
aa797bd54f44 test: add a basic 'test-check-pylint.t'
Pierre-Yves David <pierre-yves.david@ens-lyon.org>
parents:
diff changeset
    12
  $ touch $TESTTMP/fakerc
aa797bd54f44 test: add a basic 'test-check-pylint.t'
Pierre-Yves David <pierre-yves.david@ens-lyon.org>
parents:
diff changeset
    13
  $ pylint --rcfile=$TESTTMP/fakerc --disable=all \
35630
6061e54ff81d pylint: add a check for multiple statement on a single line
Boris Feld <boris.feld@octobus.net>
parents: 35627
diff changeset
    14
  >   --enable=W0102,C0321 \
35627
882998f08c3c pylint: split command line argument on multiple lines
Boris Feld <boris.feld@octobus.net>
parents: 34396
diff changeset
    15
  >   --reports=no \
34396
41401f502c83 tests: disable lints on mercurial/thirdparty
Siddharth Agarwal <sid0@fb.com>
parents: 32459
diff changeset
    16
  >   --ignore=thirdparty \
37853
6ae62d62c3f6 tests: adapt test-check-pylint to run on Windows
Matt Harbison <matt_harbison@yahoo.com>
parents: 35630
diff changeset
    17
  >   mercurial hgdemandimport hgext hgext3rd | sed 's/\r$//'
6ae62d62c3f6 tests: adapt test-check-pylint to run on Windows
Matt Harbison <matt_harbison@yahoo.com>
parents: 35630
diff changeset
    18
  Using config file *fakerc (glob) (?)
31839
5b048d5f8884 test-check-pylint: match its output
Jun Wu <quark@fb.com>
parents: 31422
diff changeset
    19
   (?)
5b048d5f8884 test-check-pylint: match its output
Jun Wu <quark@fb.com>
parents: 31422
diff changeset
    20
  ------------------------------------ (?)
5b048d5f8884 test-check-pylint: match its output
Jun Wu <quark@fb.com>
parents: 31422
diff changeset
    21
  Your code has been rated at 10.00/10 (?)
5b048d5f8884 test-check-pylint: match its output
Jun Wu <quark@fb.com>
parents: 31422
diff changeset
    22
   (?)