tests/test-parseindex2.py.out
author Gregory Szorc <gregory.szorc@gmail.com>
Fri, 14 Apr 2017 00:33:56 -0700
changeset 32002 bf855efe5664
parent 7110 75fdc39b6172
permissions -rw-r--r--
httppeer: wrap HTTPResponse.read() globally There were a handful of places in the code where HTTPResponse.read() was called with no explicit error handling or with inconsistent error handling. In order to eliminate this class of bug, we globally swap out HTTPResponse.read() with a unified error handler. I initially attempted to fix all call sites. However, after going down that rabbit hole, I figured it was best to just change read() to do what we want. This appears to be a worthwhile change, as the tests demonstrate many of our uncaught exceptions go away. To better represent this class of failure, we introduce a new error type. The main benefit over IOError is it can hold a hint. I'm receptive to tweaking its name or inheritance.
Ignore whitespace changes - Everywhere: Within whitespace: At end of lines:
7110
75fdc39b6172 Add parseindex2.py test case
Bernhard Leiner <bleiner@gmail.com>
parents:
diff changeset
     1
done