tests/test-mdiff.py
author Ian Moody <moz-ian@perix.co.uk>
Tue, 16 Jul 2019 19:18:16 +0100
changeset 42618 c17e6a3e7356
parent 36361 8d0b0b533e09
child 43076 2372284d9457
permissions -rw-r--r--
phabricator: handle local:commits time being string or int When setting local:commits arcanist has different behaviour depending on whether the repo is git or hg. With hg it sets the time as a number, since it calls PHP's strtotime on the value, but with git it sets it as a string. Normally this wouldn't be an issue since phabread wouldn't be interacting with Phabricator Revisions for git repos, but Mozilla has a secondary workflow for git users that uses the git-cinnabar tool to interact with their hg repos. When a git-cinnabar user uses the moz-phab tool to submit patches for mozilla-central it makes use of Mozilla's fork of arcanist, which works with their local git version of m-c, and thus sets the local:commit time as a string, and then translates the commit hashes. Currently when encountering such DREVS phabread dies with "TypeError: %d format: a number is required, not str". phabsend also used to set it as a string but wouldn't have encountered the issue with its own DREVs since it would read hg:meta first. Differential Revision: https://phab.mercurial-scm.org/D6650
Ignore whitespace changes - Everywhere: Within whitespace: At end of lines:
35902
1ab7b16c9437 tests: start a set of unit tests for mdiff.py, starting with splitnewlines
Augie Fackler <augie@google.com>
parents:
diff changeset
     1
from __future__ import absolute_import
1ab7b16c9437 tests: start a set of unit tests for mdiff.py, starting with splitnewlines
Augie Fackler <augie@google.com>
parents:
diff changeset
     2
from __future__ import print_function
1ab7b16c9437 tests: start a set of unit tests for mdiff.py, starting with splitnewlines
Augie Fackler <augie@google.com>
parents:
diff changeset
     3
1ab7b16c9437 tests: start a set of unit tests for mdiff.py, starting with splitnewlines
Augie Fackler <augie@google.com>
parents:
diff changeset
     4
import unittest
1ab7b16c9437 tests: start a set of unit tests for mdiff.py, starting with splitnewlines
Augie Fackler <augie@google.com>
parents:
diff changeset
     5
1ab7b16c9437 tests: start a set of unit tests for mdiff.py, starting with splitnewlines
Augie Fackler <augie@google.com>
parents:
diff changeset
     6
from mercurial import (
1ab7b16c9437 tests: start a set of unit tests for mdiff.py, starting with splitnewlines
Augie Fackler <augie@google.com>
parents:
diff changeset
     7
    mdiff,
1ab7b16c9437 tests: start a set of unit tests for mdiff.py, starting with splitnewlines
Augie Fackler <augie@google.com>
parents:
diff changeset
     8
)
1ab7b16c9437 tests: start a set of unit tests for mdiff.py, starting with splitnewlines
Augie Fackler <augie@google.com>
parents:
diff changeset
     9
1ab7b16c9437 tests: start a set of unit tests for mdiff.py, starting with splitnewlines
Augie Fackler <augie@google.com>
parents:
diff changeset
    10
class splitnewlinesTests(unittest.TestCase):
1ab7b16c9437 tests: start a set of unit tests for mdiff.py, starting with splitnewlines
Augie Fackler <augie@google.com>
parents:
diff changeset
    11
1ab7b16c9437 tests: start a set of unit tests for mdiff.py, starting with splitnewlines
Augie Fackler <augie@google.com>
parents:
diff changeset
    12
    def test_splitnewlines(self):
36361
8d0b0b533e09 py3: add b'' prefixes in test-mdiff.py
Pulkit Goyal <7895pulkit@gmail.com>
parents: 36360
diff changeset
    13
        cases = {b'a\nb\nc\n': [b'a\n', b'b\n', b'c\n'],
8d0b0b533e09 py3: add b'' prefixes in test-mdiff.py
Pulkit Goyal <7895pulkit@gmail.com>
parents: 36360
diff changeset
    14
                 b'a\nb\nc': [b'a\n', b'b\n', b'c'],
8d0b0b533e09 py3: add b'' prefixes in test-mdiff.py
Pulkit Goyal <7895pulkit@gmail.com>
parents: 36360
diff changeset
    15
                 b'a\nb\nc\n\n': [b'a\n', b'b\n', b'c\n', b'\n'],
8d0b0b533e09 py3: add b'' prefixes in test-mdiff.py
Pulkit Goyal <7895pulkit@gmail.com>
parents: 36360
diff changeset
    16
                 b'': [],
8d0b0b533e09 py3: add b'' prefixes in test-mdiff.py
Pulkit Goyal <7895pulkit@gmail.com>
parents: 36360
diff changeset
    17
                 b'abcabc': [b'abcabc'],
35902
1ab7b16c9437 tests: start a set of unit tests for mdiff.py, starting with splitnewlines
Augie Fackler <augie@google.com>
parents:
diff changeset
    18
                 }
36360
58c1368ab629 py3: use dict.items() instead of dict.iteritems() in tests
Pulkit Goyal <7895pulkit@gmail.com>
parents: 35902
diff changeset
    19
        for inp, want in cases.items():
35902
1ab7b16c9437 tests: start a set of unit tests for mdiff.py, starting with splitnewlines
Augie Fackler <augie@google.com>
parents:
diff changeset
    20
            self.assertEqual(mdiff.splitnewlines(inp), want)
1ab7b16c9437 tests: start a set of unit tests for mdiff.py, starting with splitnewlines
Augie Fackler <augie@google.com>
parents:
diff changeset
    21
1ab7b16c9437 tests: start a set of unit tests for mdiff.py, starting with splitnewlines
Augie Fackler <augie@google.com>
parents:
diff changeset
    22
if __name__ == '__main__':
1ab7b16c9437 tests: start a set of unit tests for mdiff.py, starting with splitnewlines
Augie Fackler <augie@google.com>
parents:
diff changeset
    23
    import silenttestrunner
1ab7b16c9437 tests: start a set of unit tests for mdiff.py, starting with splitnewlines
Augie Fackler <augie@google.com>
parents:
diff changeset
    24
    silenttestrunner.main(__name__)