hg-stable: CONTRIBUTING@d053d3f10b6a (annotated)

packaging: stage installed files for Inno Previously, the Inno installer maintained its own mapping of source files to install location. (We have to maintain a similar mapping in the WiX installer.) Managing the explicit file layout for Windows packages is cumbersome and redundant. Every time you want to change the layout you need to change N locations. We frequently forget to do this and we only find out when people install Mercurial from our packages at release time. This commit starts the process of consolidating and simplifying the logic for managing the install layout on Windows. We introduce a list of install layout rules. These are simply source filenames (which can contain wildcards) and destination paths. The Inno packaging code has been updated to assemble all files into a staging directory that mirrors the final install layout. The list of files to add to the installer is derived by walking this staging directory and dynamically emitting the proper entries for the Inno Setup script. I diffed the file layout before and after this commit and there is no difference. Another benefit of this change is that it facilitates easier testing of the Windows install layout. Before, in order to test the final install layout, you needed to build an installer and run it. Now, you can stage files into the final layout and test from there, without running the installer. This should cut down on overhead when changing Windows code. Differential Revision: https://phab.mercurial-scm.org/D7159

30084 a492610a2fc1 contributing: add new file with a pointer to the wiki Augie Fackler <augie@google.com> parents: diff changeset	1	Our full contribution guidelines are in our wiki, please see:
a492610a2fc1 contributing: add new file with a pointer to the wiki Augie Fackler <augie@google.com> parents: diff changeset	2
a492610a2fc1 contributing: add new file with a pointer to the wiki Augie Fackler <augie@google.com> parents: diff changeset	3	https://www.mercurial-scm.org/wiki/ContributingChanges
a492610a2fc1 contributing: add new file with a pointer to the wiki Augie Fackler <augie@google.com> parents: diff changeset	4
a492610a2fc1 contributing: add new file with a pointer to the wiki Augie Fackler <augie@google.com> parents: diff changeset	5	If you just want a checklist to follow, you can go straight to
a492610a2fc1 contributing: add new file with a pointer to the wiki Augie Fackler <augie@google.com> parents: diff changeset	6
a492610a2fc1 contributing: add new file with a pointer to the wiki Augie Fackler <augie@google.com> parents: diff changeset	7	https://www.mercurial-scm.org/wiki/ContributingChanges#Submission_checklist
a492610a2fc1 contributing: add new file with a pointer to the wiki Augie Fackler <augie@google.com> parents: diff changeset	8
a492610a2fc1 contributing: add new file with a pointer to the wiki Augie Fackler <augie@google.com> parents: diff changeset	9	If you can't run the entire testsuite for some reason (it can be
a492610a2fc1 contributing: add new file with a pointer to the wiki Augie Fackler <augie@google.com> parents: diff changeset	10	difficult on Windows), please at least run `contrib/check-code.py` on
a492610a2fc1 contributing: add new file with a pointer to the wiki Augie Fackler <augie@google.com> parents: diff changeset	11	any files you've modified and run `python contrib/check-commit` on any
a492610a2fc1 contributing: add new file with a pointer to the wiki Augie Fackler <augie@google.com> parents: diff changeset	12	commits you've made (for example, `python contrib/check-commit
a492610a2fc1 contributing: add new file with a pointer to the wiki Augie Fackler <augie@google.com> parents: diff changeset	13	273ce12ad8f1` will report some style violations on a very old commit).

author	Gregory Szorc <gregory.szorc@gmail.com>
	Wed, 23 Oct 2019 18:39:28 -0700
changeset 43564	d053d3f10b6a
parent 30084	a492610a2fc1
permissions	-rw-r--r--