tests/test-debian-packages.t
author Georges Racinet <georges.racinet@octobus.net>
Tue, 20 Jul 2021 17:20:19 +0200
changeset 47909 de2e04fe4897
parent 43320 7b638d25b8e4
child 50722 7e5be4a7cda7
permissions -rw-r--r--
hgwebdir: avoid systematic full garbage collection Forcing a systematic full garbage collection upon each request can serioulsy harm performance. This is reported as https://bz.mercurial-scm.org/show_bug.cgi?id=6075 With this change we're performing the full collection according to a new setting, `experimental.web.full-garbage-collection-rate`. The default value is 1, which doesn't change the behavior and will allow us to test on real use cases. If the value is 0, no full garbage collection occurs. Regardless of the value of the setting, a partial garbage collection still occurs upon each request (not attempting to collect objects from the oldest generation). This should be enough to take care of reference cycles that have been created by the last request (assessment of this requires changing the setting, not to be 1). In my experience chasing memory leaks in Mercurial servers, the full collection never reclaimed any memory, but this is with Python 3 and biased towards small repositories. On the other hand, as explained in the Python developer docs [1], frequent full collections are very harmful in terms of performance if lots of objects survive the collection, and hence stay in the oldest generation. Note that `gc.collect()` is indeed trying to collect the oldest generation [2]. This happens usually in two cases: - unwanted lingering objects (i.e., an actual memory leak that the GC cannot do anything about). Sadly, we have lots of those these days. - desireable long-term objects, typically in caches (not inner caches carried by repositories, which should be collected with them). This is a subject of interest for the Heptapod project. In short, the flat rate that this change still permits is probably a bad idea in most cases, and the default value can be tweaked later on (or even be set to 0) according to experiments in the wild. The test is inspired from test-hgwebdir-paths.py [1] https://devguide.python.org/garbage_collector/#collecting-the-oldest-generation [2] https://docs.python.org/3/library/gc.html#gc.collect Differential Revision: https://phab.mercurial-scm.org/D11204
Ignore whitespace changes - Everywhere: Within whitespace: At end of lines:
34402
13d3f8aaed87 tests: add "have" check for dpkg builddeps
Kyle Lippincott <spectral@google.com>
parents: 34401
diff changeset
     1
#require test-repo slow debhelper debdeps
26148
7f49efcaa9b4 debian: switch to using debhelper and dh_python2 to build debs
Augie Fackler <augie@google.com>
parents: 26147
diff changeset
     2
29219
3c9066ed557c tests: silence test-repo obsolete warning
timeless <timeless@mozdev.org>
parents: 26148
diff changeset
     3
  $ . "$TESTDIR/helpers-testrepo.sh"
33204
ddd65b4f3ae6 tests: alias syshg and syshgenv so they can be switched conditionally
Yuya Nishihara <yuya@tcha.org>
parents: 33128
diff changeset
     4
  $ testrepohgenv
29219
3c9066ed557c tests: silence test-repo obsolete warning
timeless <timeless@mozdev.org>
parents: 26148
diff changeset
     5
26148
7f49efcaa9b4 debian: switch to using debhelper and dh_python2 to build debs
Augie Fackler <augie@google.com>
parents: 26147
diff changeset
     6
Ensure debuild doesn't run the testsuite, as that could get silly.
7f49efcaa9b4 debian: switch to using debhelper and dh_python2 to build debs
Augie Fackler <augie@google.com>
parents: 26147
diff changeset
     7
  $ DEB_BUILD_OPTIONS=nocheck
7f49efcaa9b4 debian: switch to using debhelper and dh_python2 to build debs
Augie Fackler <augie@google.com>
parents: 26147
diff changeset
     8
  $ export DEB_BUILD_OPTIONS
26147
a02c22e48142 test-debian-packages: new test for testing construction of debian packages
Augie Fackler <augie@google.com>
parents:
diff changeset
     9
  $ OUTPUTDIR=`pwd`
a02c22e48142 test-debian-packages: new test for testing construction of debian packages
Augie Fackler <augie@google.com>
parents:
diff changeset
    10
  $ export OUTPUTDIR
a02c22e48142 test-debian-packages: new test for testing construction of debian packages
Augie Fackler <augie@google.com>
parents:
diff changeset
    11
a02c22e48142 test-debian-packages: new test for testing construction of debian packages
Augie Fackler <augie@google.com>
parents:
diff changeset
    12
  $ cd "$TESTDIR"/..
a02c22e48142 test-debian-packages: new test for testing construction of debian packages
Augie Fackler <augie@google.com>
parents:
diff changeset
    13
  $ make deb > $OUTPUTDIR/build.log 2>&1
a02c22e48142 test-debian-packages: new test for testing construction of debian packages
Augie Fackler <augie@google.com>
parents:
diff changeset
    14
  $ cd $OUTPUTDIR
34401
3d936da4f97b tests: expect parsers.so in cext, parsers.py in pure (test-debian-packages)
Kyle Lippincott <spectral@google.com>
parents: 33204
diff changeset
    15
  $ ls *.deb | grep -v 'dbg'
26148
7f49efcaa9b4 debian: switch to using debhelper and dh_python2 to build debs
Augie Fackler <augie@google.com>
parents: 26147
diff changeset
    16
  mercurial_*.deb (glob)
43320
7b638d25b8e4 packaging: ship only a single binary Debian package
Denis Laxalde <denis.laxalde@logilab.fr>
parents: 43310
diff changeset
    17
should have .so and .py
26148
7f49efcaa9b4 debian: switch to using debhelper and dh_python2 to build debs
Augie Fackler <augie@google.com>
parents: 26147
diff changeset
    18
  $ dpkg --contents mercurial_*.deb | egrep '(localrepo|parsers)'
43310
7574ccd87200 packaging: upgrade Debian packaging to build with Python 3
Denis Laxalde <denis@laxalde.org>
parents: 34407
diff changeset
    19
  * ./usr/lib/python3/dist-packages/mercurial/cext/parsers*.so (glob)
7574ccd87200 packaging: upgrade Debian packaging to build with Python 3
Denis Laxalde <denis@laxalde.org>
parents: 34407
diff changeset
    20
  * ./usr/lib/python3/dist-packages/mercurial/localrepo.py (glob)
43320
7b638d25b8e4 packaging: ship only a single binary Debian package
Denis Laxalde <denis.laxalde@logilab.fr>
parents: 43310
diff changeset
    21
  * ./usr/lib/python3/dist-packages/mercurial/pure/parsers.py (glob)
7b638d25b8e4 packaging: ship only a single binary Debian package
Denis Laxalde <denis.laxalde@logilab.fr>
parents: 43310
diff changeset
    22
should have zsh completions
7b638d25b8e4 packaging: ship only a single binary Debian package
Denis Laxalde <denis.laxalde@logilab.fr>
parents: 43310
diff changeset
    23
  $ dpkg --contents mercurial_*.deb | egrep 'zsh.*[^/]$'
34406
9ecc622ca23f deb: install zsh completions to /usr/share/zsh/vendor-completions
Kyle Lippincott <spectral@google.com>
parents: 34402
diff changeset
    24
  * ./usr/share/zsh/vendor-completions/_hg (glob)
43320
7b638d25b8e4 packaging: ship only a single binary Debian package
Denis Laxalde <denis.laxalde@logilab.fr>
parents: 43310
diff changeset
    25
should have chg
34407
0133ca39c688 deb: build and install chg
Kyle Lippincott <spectral@google.com>
parents: 34406
diff changeset
    26
  $ dpkg --contents mercurial_*.deb | egrep 'chg$'
0133ca39c688 deb: build and install chg
Kyle Lippincott <spectral@google.com>
parents: 34406
diff changeset
    27
  * ./usr/bin/chg (glob)
0133ca39c688 deb: build and install chg
Kyle Lippincott <spectral@google.com>
parents: 34406
diff changeset
    28
chg should come with a man page
0133ca39c688 deb: build and install chg
Kyle Lippincott <spectral@google.com>
parents: 34406
diff changeset
    29
  $ dpkg --contents mercurial_*.deb | egrep 'man.*chg'
0133ca39c688 deb: build and install chg
Kyle Lippincott <spectral@google.com>
parents: 34406
diff changeset
    30
  * ./usr/share/man/man1/chg.1.gz (glob)