comparison mercurial/revset.py @ 22825:0e8bb81b58b9

baseset: stop inheriting from built-in list class

The baseset is doing more and more smartset magic and using its list-like
property less and less. So we store the list of revisions in an explicit
attribute and stop inheriting.

This requires reimplementing some basic methods.

22824:9271630f4720

            kwargs['ascending'] = True
        elif self.isdescending():
            kwargs['ascending'] = False
        return filteredset(self, condition, **kwargs)

class baseset(list, abstractsmartset):
    """Basic data structure that represents a revset and contains the basic
    operation that it should be able to perform.

    Every method in this class should be implemented by any smartset class.
    """
    def __init__(self, data=()):
        super(baseset, self).__init__(data)
        self._set = None

    def set(self):
        """Returns a set or a smartset containing all the elements.

    @util.propertycache
    def __contains__(self):
        return self.set().__contains__

    def __nonzero__(self):
        return bool(len(self))

    def __sub__(self, other):
        """Returns a new object with the substraction of the two collections.

        This is part of the mandatory API for smartset."""

        This is part of the mandatory API for smartset."""
        return False

    def first(self):
        if self:
            return self[0]
        return None

    def last(self):
        if self:
            return self[-1]
        return None

class filteredset(abstractsmartset):
    """Duck type for baseset class which iterates lazily over the revisions in
    the subset and contains a function which tests for membership in the

22825:0e8bb81b58b9

            kwargs['ascending'] = True
        elif self.isdescending():
            kwargs['ascending'] = False
        return filteredset(self, condition, **kwargs)

class baseset(abstractsmartset):
    """Basic data structure that represents a revset and contains the basic
    operation that it should be able to perform.

    Every method in this class should be implemented by any smartset class.
    """
    def __init__(self, data=()):
        if not isinstance(data, list):
            data = list(data)
        self._list = data
        self._set = None

    def set(self):
        """Returns a set or a smartset containing all the elements.

    @util.propertycache
    def __contains__(self):
        return self.set().__contains__

    def __nonzero__(self):
        return bool(self._list)

    def sort(self, reverse=False):
        self._list.sort(reverse=reverse)

    def reverse(self):
        self._list.reverse()

    def __iter__(self):
        return iter(self._list)

    def __len__(self):
        return len(self._list)

    def __sub__(self, other):
        """Returns a new object with the substraction of the two collections.

        This is part of the mandatory API for smartset."""

        This is part of the mandatory API for smartset."""
        return False

    def first(self):
        if self:
            return self._list[0]
        return None

    def last(self):
        if self:
            return self._list[-1]
        return None

class filteredset(abstractsmartset):
    """Duck type for baseset class which iterates lazily over the revisions in
    the subset and contains a function which tests for membership in the