comparison mercurial/commands.py @ 9584:17da88da1abd

bisect: use util.system and fix good/bad when using -c

The existing scheme using util.find_exe and subprocess.call meant we
couldn't use simple shell commands in tests. Fix that.

Also, it mistakenly used status from the system() call rather than
good from the bisect call in reporting results.

9583:0491be4448bf

        return

    state = hbisect.load_state(repo)

    if command:
        commandpath = util.find_exe(command)
        if commandpath is None:
            raise util.Abort(_("cannot find executable: %s") % command)
        changesets = 1
        try:
            while changesets:
                # update state
                status = subprocess.call([commandpath])
                if status == 125:
                    transition = "skip"
                elif status == 0:
                    transition = "good"
                # status < 0 means process was killed

                # update to next check
                cmdutil.bail_if_changed(repo)
                hg.clean(repo, nodes[0], show_stats=False)
        finally:
            hbisect.save_state(repo, state)
        return print_result(nodes, not status)

    # update state
    node = repo.lookup(rev or '.')
    if good:
        state['good'].append(node)

9584:17da88da1abd

        return

    state = hbisect.load_state(repo)

    if command:
        changesets = 1
        try:
            while changesets:
                # update state
                status = util.system(command)
                if status == 125:
                    transition = "skip"
                elif status == 0:
                    transition = "good"
                # status < 0 means process was killed

                # update to next check
                cmdutil.bail_if_changed(repo)
                hg.clean(repo, nodes[0], show_stats=False)
        finally:
            hbisect.save_state(repo, state)
        return print_result(nodes, good)

    # update state
    node = repo.lookup(rev or '.')
    if good:
        state['good'].append(node)