comparison mercurial/util.py @ 49909:1d1b244a91b6

util: fix the signature of observedbufferedinputpipe._fillbuffer()

Flagged by PyCharm, since it didn't match the signature of the method being
overridden.  The default value in the superclass is also `_chunksize`, and I
suspect that the amount read from `osread` should be limited to what is passed
in.  Only one caller (`bufferedinputpipe.unbufferedread()`) passes this
argument, and it passes the max of `_chunksize` and whatever it was passed.

49908:54114bba7c7e

    This variation of ``bufferedinputpipe`` can notify observers about
    ``os.read()`` events. It also re-publishes other events, such as
    ``read()`` and ``readline()``.
    """

    def _fillbuffer(self):
        res = super(observedbufferedinputpipe, self)._fillbuffer()

        fn = getattr(self._input._observer, 'osread', None)
        if fn:
            fn(res, _chunksize)

        return res

    # We use different observer methods because the operation isn't
    # performed on the actual file object but on us.

49909:1d1b244a91b6

    This variation of ``bufferedinputpipe`` can notify observers about
    ``os.read()`` events. It also re-publishes other events, such as
    ``read()`` and ``readline()``.
    """

    def _fillbuffer(self, size=_chunksize):
        res = super(observedbufferedinputpipe, self)._fillbuffer(size=size)

        fn = getattr(self._input._observer, 'osread', None)
        if fn:
            fn(res, size)

        return res

    # We use different observer methods because the operation isn't
    # performed on the actual file object but on us.