comparison hgext/fix.py @ 42773:2d70b1118af2

fix: correctly parse the :metadata subconfig

It's being handled as a string instead of a bool, though the thruthiness of the
string makes the feature still essentially work. Added a regression test.

Differential Revision: https://phab.mercurial-scm.org/D6726

42772:ed0da6e0d6ee

FIXER_ATTRS = {
    'command': None,
    'linerange': None,
    'pattern': None,
    'priority': 0,
    'metadata': False,
    'skipclean': 'true',
}

for key, default in FIXER_ATTRS.items():
    configitem('fix', '.*(:%s)?' % key, default=default, generic=True)

        attrs = ui.configsuboptions('fix', name)[1]
        for key, default in FIXER_ATTRS.items():
            setattr(fixers[name], pycompat.sysstr('_' + key),
                    attrs.get(key, default))
        fixers[name]._priority = int(fixers[name]._priority)
        fixers[name]._skipclean = stringutil.parsebool(fixers[name]._skipclean)
        # Don't use a fixer if it has no pattern configured. It would be
        # dangerous to let it affect all files. It would be pointless to let it
        # affect no files. There is no reasonable subset of files to use as the
        # default.

42773:2d70b1118af2

FIXER_ATTRS = {
    'command': None,
    'linerange': None,
    'pattern': None,
    'priority': 0,
    'metadata': 'false',
    'skipclean': 'true',
}

for key, default in FIXER_ATTRS.items():
    configitem('fix', '.*(:%s)?' % key, default=default, generic=True)

        attrs = ui.configsuboptions('fix', name)[1]
        for key, default in FIXER_ATTRS.items():
            setattr(fixers[name], pycompat.sysstr('_' + key),
                    attrs.get(key, default))
        fixers[name]._priority = int(fixers[name]._priority)
        fixers[name]._metadata = stringutil.parsebool(fixers[name]._metadata)
        fixers[name]._skipclean = stringutil.parsebool(fixers[name]._skipclean)
        # Don't use a fixer if it has no pattern configured. It would be
        # dangerous to let it affect all files. It would be pointless to let it
        # affect no files. There is no reasonable subset of files to use as the
        # default.