comparison mercurial/cmdutil.py @ 21576:33395a7e5527

revert: group action into a single dictionary

We had 4 different variables to hold the list of the 4 possibles
actions. I'm grouping them in a single dictionary for a few reasons.
First, it makes it clearer they are all related and meant to be the
final actions performed by revert. Second this simplifies the parameter
of the _performrevert function. Finally the two elements in each entry
(list and message) have a different consumers in different functions,
this change will make it easier to split them in a later commit.

21575:8262c2a39ab8

                return _('forgetting %s\n')
            return _('removing %s\n')

        # action to be actually performed by revert
        # (<list of file>, message>) tuple
        revert = ([], _('reverting %s\n'))
        add = ([], _('adding %s\n'))
        remove = ([], removeforget)
        undelete = ([], _('undeleting %s\n'))

        disptable = (
            # dispatch table:
            #   file state
            #   action if in target manifest
            #   action if not in target manifest
            #   make backup if in target manifest
            #   make backup if not in target manifest
            (modified, revert,   remove, True,  True),
            (added,    revert,   remove, True,  False),
            (removed,  undelete, None,   True,  False),
            (deleted,  revert,   remove, False, False),
            )

        for abs, (rel, exact) in sorted(names.items()):
            # hash on file in target manifest (or None if missing from target)
            mfentry = mf.get(abs)

                # Not touched in current dirstate.

                # file is unknown in parent, restore older version or ignore.
                if abs not in repo.dirstate:
                    if mfentry:
                        handle(add, True)
                    elif exact:
                        ui.warn(_('file not managed: %s\n') % rel)
                    continue

                # parent is target, no changes mean no changes

                if abs in pmf and mfentry:
                    # if version of file is same in parent and target
                    # manifests, do nothing
                    if (pmf[abs] != mfentry or
                        pmf.flags(abs) != mf.flags(abs)):
                        handle(revert, False)
                else:
                    handle(remove, False)
        if not opts.get('dry_run'):
            _performrevert(repo, parents, ctx, revert, add, remove, undelete)

            if targetsubs:
                # Revert the subrepos on the revert list
                for sub in targetsubs:
                    ctx.sub(sub).revert(ui, ctx.substate[sub], *pats, **opts)
    finally:
        wlock.release()

def _performrevert(repo, parents, ctx, revert, add, remove, undelete):
    """function that actually perform all the action computed for revert

    This is an independent function to let extension to plug in and react to
    the imminent revert.

    Make sure you have the working directory locked when calling this function.

    def checkout(f):
        fc = ctx[f]
        repo.wwrite(f, fc.data(), fc.flags())

    audit_path = pathutil.pathauditor(repo.root)
    for f in remove[0]:
        if repo.dirstate[f] == 'a':
            repo.dirstate.drop(f)
            continue
        audit_path(f)
        try:

        # merges to avoid losing information about merged/dirty files.
        if p2 != nullid:
            normal = repo.dirstate.normallookup
        else:
            normal = repo.dirstate.normal
    for f in revert[0]:
        checkout(f)
        if normal:
            normal(f)

    for f in add[0]:
        checkout(f)
        repo.dirstate.add(f)

    normal = repo.dirstate.normallookup
    if node == parent and p2 == nullid:
        normal = repo.dirstate.normal
    for f in undelete[0]:
        checkout(f)
        normal(f)

    copied = copies.pathcopies(repo[parent], ctx)

    for f in add[0] + undelete[0] + revert[0]:
        if f in copied:
            repo.dirstate.copy(copied[f], f)

def command(table):
    '''returns a function object bound to table which can be used as

21576:33395a7e5527

                return _('forgetting %s\n')
            return _('removing %s\n')

        # action to be actually performed by revert
        # (<list of file>, message>) tuple
        actions = {'revert': ([], _('reverting %s\n')),
                   'add': ([], _('adding %s\n')),
                   'remove': ([], removeforget),
                   'undelete': ([], _('undeleting %s\n'))}

        disptable = (
            # dispatch table:
            #   file state
            #   action if in target manifest
            #   action if not in target manifest
            #   make backup if in target manifest
            #   make backup if not in target manifest
            (modified, actions['revert'],   actions['remove'], True,  True),
            (added,    actions['revert'],   actions['remove'], True,  False),
            (removed,  actions['undelete'], None,              True,  False),
            (deleted,  actions['revert'],   actions['remove'], False, False),
            )

        for abs, (rel, exact) in sorted(names.items()):
            # hash on file in target manifest (or None if missing from target)
            mfentry = mf.get(abs)

                # Not touched in current dirstate.

                # file is unknown in parent, restore older version or ignore.
                if abs not in repo.dirstate:
                    if mfentry:
                        handle(actions['add'], True)
                    elif exact:
                        ui.warn(_('file not managed: %s\n') % rel)
                    continue

                # parent is target, no changes mean no changes

                if abs in pmf and mfentry:
                    # if version of file is same in parent and target
                    # manifests, do nothing
                    if (pmf[abs] != mfentry or
                        pmf.flags(abs) != mf.flags(abs)):
                        handle(actions['revert'], False)
                else:
                    handle(actions['remove'], False)

        if not opts.get('dry_run'):
            _performrevert(repo, parents, ctx, actions)

            if targetsubs:
                # Revert the subrepos on the revert list
                for sub in targetsubs:
                    ctx.sub(sub).revert(ui, ctx.substate[sub], *pats, **opts)
    finally:
        wlock.release()

def _performrevert(repo, parents, ctx, actions):
    """function that actually perform all the actions computed for revert

    This is an independent function to let extension to plug in and react to
    the imminent revert.

    Make sure you have the working directory locked when calling this function.

    def checkout(f):
        fc = ctx[f]
        repo.wwrite(f, fc.data(), fc.flags())

    audit_path = pathutil.pathauditor(repo.root)
    for f in actions['remove'][0]:
        if repo.dirstate[f] == 'a':
            repo.dirstate.drop(f)
            continue
        audit_path(f)
        try:

        # merges to avoid losing information about merged/dirty files.
        if p2 != nullid:
            normal = repo.dirstate.normallookup
        else:
            normal = repo.dirstate.normal
    for f in actions['revert'][0]:
        checkout(f)
        if normal:
            normal(f)

    for f in actions['add'][0]:
        checkout(f)
        repo.dirstate.add(f)

    normal = repo.dirstate.normallookup
    if node == parent and p2 == nullid:
        normal = repo.dirstate.normal
    for f in actions['undelete'][0]:
        checkout(f)
        normal(f)

    copied = copies.pathcopies(repo[parent], ctx)

    for f in actions['add'][0] + actions['undelete'][0] + actions['revert'][0]:
        if f in copied:
            repo.dirstate.copy(copied[f], f)

def command(table):
    '''returns a function object bound to table which can be used as