45 [ |
45 [ |
46 (r'(pushd|popd)', "don't use 'pushd' or 'popd', use 'cd'"), |
46 (r'(pushd|popd)', "don't use 'pushd' or 'popd', use 'cd'"), |
47 (r'\W\$?\(\([^\)\n]*\)\)', "don't use (()) or $(()), use 'expr'"), |
47 (r'\W\$?\(\([^\)\n]*\)\)', "don't use (()) or $(()), use 'expr'"), |
48 (r'^function', "don't use 'function', use old style"), |
48 (r'^function', "don't use 'function', use old style"), |
49 (r'grep.*-q', "don't use 'grep -q', redirect to /dev/null"), |
49 (r'grep.*-q', "don't use 'grep -q', redirect to /dev/null"), |
|
50 (r'sed.*-i', "don't use 'sed -i', use a temporary file"), |
50 (r'echo.*\\n', "don't use 'echo \\n', use printf"), |
51 (r'echo.*\\n', "don't use 'echo \\n', use printf"), |
51 (r'echo -n', "don't use 'echo -n', use printf"), |
52 (r'echo -n', "don't use 'echo -n', use printf"), |
52 (r'^diff.*-\w*N', "don't use 'diff -N'"), |
53 (r'^diff.*-\w*N', "don't use 'diff -N'"), |
53 (r'(^| )wc[^|]*$\n(?!.*\(re\))', "filter wc output"), |
54 (r'(^| )wc[^|]*$\n(?!.*\(re\))', "filter wc output"), |
54 (r'head -c', "don't use 'head -c', use 'dd'"), |
55 (r'head -c', "don't use 'head -c', use 'dd'"), |