Mercurial > hg-stable
comparison hgext/win32mbcs.py @ 29893:6f447b9ec263
util: rename checkcase() to fscasesensitive() (API)
I always read the name "checkcase(path)" as "do we need to check for
case folding at this path", but it's actually (I think) meant to be
read "check if the file system cares about case at this path". I'm
clearly not the only one confused by this as the dirstate has this
property:
def _checkcase(self):
return not util.checkcase(self._join('.hg'))
Maybe we should even inverse the function and call it fscasefolding()
since that's what all callers care about?
author | Martin von Zweigbergk <martinvonz@google.com> |
---|---|
date | Tue, 30 Aug 2016 09:22:53 -0700 |
parents | d5883fd055c6 |
children | 8a9681b963a3 |
comparison
equal
deleted
inserted
replaced
29892:8a84347b9907 | 29893:6f447b9ec263 |
---|---|
146 | 146 |
147 # List of functions to be wrapped. | 147 # List of functions to be wrapped. |
148 # NOTE: os.path.dirname() and os.path.basename() are safe because | 148 # NOTE: os.path.dirname() and os.path.basename() are safe because |
149 # they use result of os.path.split() | 149 # they use result of os.path.split() |
150 funcs = '''os.path.join os.path.split os.path.splitext | 150 funcs = '''os.path.join os.path.split os.path.splitext |
151 os.path.normpath os.makedirs | 151 os.path.normpath os.makedirs mercurial.util.endswithsep |
152 mercurial.util.endswithsep mercurial.util.splitpath mercurial.util.checkcase | 152 mercurial.util.splitpath mercurial.util.fscasesensitive |
153 mercurial.util.fspath mercurial.util.pconvert mercurial.util.normpath | 153 mercurial.util.fspath mercurial.util.pconvert mercurial.util.normpath |
154 mercurial.util.checkwinfilename mercurial.util.checkosfilename | 154 mercurial.util.checkwinfilename mercurial.util.checkosfilename |
155 mercurial.util.split''' | 155 mercurial.util.split''' |
156 | 156 |
157 # These functions are required to be called with local encoded string | 157 # These functions are required to be called with local encoded string |