comparison contrib/check-code.py @ 37890:8fb9985382be

pycompat: export queue module instead of symbols in module (API)

Previously, pycompat and util re-exported individual symbols from the
queue module. This had the side-effect of forcing the loading of the
queue module whenever pycompat/util was imported.

These symbols aren't used very often. So importing the module to
get a handle on the symbols is wasteful.

This commit changes pycompat so it no longer exports the individual
symbols in the queue module. Instead, we make the imported module
a "public" symbol. We drop the individual symbol aliases from the
util module. All consumers are updated to use pycompat.queue.* instead.

This change makes 300 invocations of `hg log -r. -T '{rev}\n'` a little
faster:

before: 18.44s
after:  17.87s

Differential Revision: https://phab.mercurial-scm.org/D3441

37889:670eb4fa1b86

    # XXX only catch mutable arguments on the first line of the definition
    (r'def.*[( ]\w+=\{\}', "don't use mutable default arguments"),
    (r'\butil\.Abort\b', "directly use error.Abort"),
    (r'^@(\w*\.)?cachefunc', "module-level @cachefunc is risky, please avoid"),
    (r'^import atexit', "don't use atexit, use ui.atexit"),
    (r'^import Queue', "don't use Queue, use util.queue + util.empty"),
    (r'^import cStringIO', "don't use cStringIO.StringIO, use util.stringio"),
    (r'^import urllib', "don't use urllib, use util.urlreq/util.urlerr"),
    (r'^import SocketServer', "don't use SockerServer, use util.socketserver"),
    (r'^import urlparse', "don't use urlparse, use util.urlreq"),
    (r'^import xmlrpclib', "don't use xmlrpclib, use util.xmlrpclib"),

37890:8fb9985382be

    # XXX only catch mutable arguments on the first line of the definition
    (r'def.*[( ]\w+=\{\}', "don't use mutable default arguments"),
    (r'\butil\.Abort\b', "directly use error.Abort"),
    (r'^@(\w*\.)?cachefunc', "module-level @cachefunc is risky, please avoid"),
    (r'^import atexit', "don't use atexit, use ui.atexit"),
    (r'^import Queue', "don't use Queue, use pycompat.queue.Queue + "
                       "pycompat.queue.Empty"),
    (r'^import cStringIO', "don't use cStringIO.StringIO, use util.stringio"),
    (r'^import urllib', "don't use urllib, use util.urlreq/util.urlerr"),
    (r'^import SocketServer', "don't use SockerServer, use util.socketserver"),
    (r'^import urlparse', "don't use urlparse, use util.urlreq"),
    (r'^import xmlrpclib', "don't use xmlrpclib, use util.xmlrpclib"),