Mercurial > hg-stable
diff mercurial/wireproto.py @ 36021:5a56bf4180ad
wireproto: function for testing if wire protocol command is available
Currently, we perform simple membership testing for whether a wire
command is available. In the future, not all wire protocol commands
will be available on all transports. For example, a legacy transport
may not support newer commands.
In preparation of this, teach the protocol handlers to call into a
function to determine if a wire protocol command is available. That
function currently does membership testing like before, so behavior
should be identical.
In the case of the HTTP server, behavior is a bit wonkier. "cmd" is
used by both the wire protocol and hgweb. We do want the protocol
handler to handle requests for all commands that look like wire
protocol commands, even if they aren't available. Otherwise, the
fallback to hgweb would only confuse automated clients and make it
easier for hgweb to accidentally implement a "cmd" that is identical
to wire protocol commands (since they aren't centrally registered).
Differential Revision: https://phab.mercurial-scm.org/D1999
author | Gregory Szorc <gregory.szorc@gmail.com> |
---|---|
date | Tue, 30 Jan 2018 18:41:44 -0800 |
parents | ef683a0fd21f |
children | 2ad145fbde54 |
line wrap: on
line diff
--- a/mercurial/wireproto.py Wed Jan 31 14:05:11 2018 -0800 +++ b/mercurial/wireproto.py Tue Jan 30 18:41:44 2018 -0800 @@ -691,6 +691,12 @@ return super(commanddict, self).__setitem__(k, v) + def commandavailable(self, command, proto): + """Determine if a command is available for the requested protocol.""" + # For now, commands are available for all protocols. So do a simple + # membership test. + return command in self + commands = commanddict() def wireprotocommand(name, args=''):