diff mercurial/wireprotoserver.py @ 37535:69e46c1834ac

wireproto: define and expose types of wire command arguments

Exposing the set of argument names is cool. But with wire protocol
version 2, we're using CBOR to transport arguments and this allows us
to have typing for arguments.

Typed arguments are much nicer because they will cut down on transfer
overhead and processing overhead for decoding values.

This commit teaches @wireprotocommand to accept a dictionary for
arguments. The arguments registered for version 2 transports are
canonically stored as dictionaries rather than a space-delimited string.

It is an error to defined arguments with a dictionary for commands using
version 1 transports. This reinforces my intent to fully decouple command
handlers for version 2 transports.

Differential Revision: https://phab.mercurial-scm.org/D3202

--- a/mercurial/wireprotoserver.py	Fri Apr 06 16:49:57 2018 -0700
+++ b/mercurial/wireprotoserver.py	Fri Apr 06 17:14:06 2018 -0700
@@ -606,10 +606,11 @@
 
     def getargs(self, args):
         data = {}
-        for k in args.split():
+        for k, typ in args.items():
             if k == '*':
                 raise NotImplementedError('do not support * args')
             elif k in self._args:
+                # TODO consider validating value types.
                 data[k] = self._args[k]
 
         return data