Mercurial > hg-stable
diff tests/test-push-race.t @ 33314:7d8d2da4516c
tests: fix reference to undefined variable
The delaypush() function had a reference to "repo" that was clearly
supposed to be "pushop.repo". Instead of just fixing that, let's
extract "pushop.repo.ui" to a variable, since that's the only
piece of the repo that's needed in the function.
I have not looked into why I saw a different result in the test to
start with, but that's for another patch anyway.
author | Martin von Zweigbergk <martinvonz@google.com> |
---|---|
date | Thu, 06 Jul 2017 14:17:02 -0700 |
parents | 8e6f4939a69a |
children | b11e8c67fb0f |
line wrap: on
line diff
--- a/tests/test-push-race.t Tue Dec 01 09:19:54 2015 -0800 +++ b/tests/test-push-race.t Thu Jul 06 14:17:02 2017 -0700 @@ -27,21 +27,22 @@ > > def delaypush(orig, pushop): > # notify we are done preparing - > readypath = pushop.repo.ui.config('delaypush', 'ready-path', None) + > ui = pushop.repo.ui + > readypath = ui.config('delaypush', 'ready-path', None) > if readypath is not None: > with open(readypath, 'w') as r: > r.write('foo') - > pushop.repo.ui.status('wrote ready: %s\n' % readypath) + > ui.status('wrote ready: %s\n' % readypath) > # now wait for the other process to be done - > watchpath = pushop.repo.ui.config('delaypush', 'release-path', None) + > watchpath = ui.config('delaypush', 'release-path', None) > if watchpath is not None: - > pushop.repo.ui.status('waiting on: %s\n' % watchpath) + > ui.status('waiting on: %s\n' % watchpath) > limit = 100 > while 0 < limit and not os.path.exists(watchpath): > limit -= 1 > time.sleep(0.1) > if limit <= 0: - > repo.ui.warn('exiting without watchfile: %s' % watchpath) + > ui.warn('exiting without watchfile: %s' % watchpath) > else: > # delete the file at the end of the push > def delete():