Mercurial > hg-stable
diff mercurial/sshpeer.py @ 46702:a4c19a162615
sshpeer: enable+fix warning about sshpeers not being closed explicitly
I recommend looking at this with a diff that ignores indentation.
The test changes are because localrepo.close() updates some cache,
which appears happens earlier now on rollbacks or strips or something.
The http changes are because httppeer.close() prints stats with
--verbose.
Differential Revision: https://phab.mercurial-scm.org/D9999
| author | Valentin Gatien-Baron <valentin.gatienbaron@gmail.com> |
|---|---|
| date | Mon, 15 Feb 2021 14:48:36 -0500 |
| parents | db8037e38085 |
| children | fa30292b680b |
line wrap: on
line diff
--- a/mercurial/sshpeer.py Mon Feb 15 14:40:17 2021 -0500 +++ b/mercurial/sshpeer.py Mon Feb 15 14:48:36 2021 -0500 @@ -175,10 +175,7 @@ # to deadlocks due to a peer get gc'ed in a fork # We add our own stack trace, because the stacktrace when called # from __del__ is useless. - if False: # enabled in next commit - ui.develwarn( - b'missing close on SSH connection created at:\n%s' % warn - ) + ui.develwarn(b'missing close on SSH connection created at:\n%s' % warn) def _makeconnection(ui, sshcmd, args, remotecmd, path, sshenv=None):