Mercurial > hg-stable
diff mercurial/extensions.py @ 48038:a9bedc56f025
extensions: prevent a crash on py3 when testing a bad extension minimum
A `None` placeholder is populated for each missing component by
`util.versiontuple()`, which could safely be used with `>` on py2, but not py3.
I guess there's another hole here where if the string is entirely bogus (i.e no
numbers), it will be treated as 0.0, and always load. But that's always been
the case.
Differential Revision: https://phab.mercurial-scm.org/D11475
| author | Matt Harbison <matt_harbison@yahoo.com> |
|---|---|
| date | Mon, 20 Sep 2021 14:16:10 -0400 |
| parents | 7bafe40ab78a |
| children | 5caec48d9a01 |
line wrap: on
line diff
--- a/mercurial/extensions.py Mon Sep 20 11:22:27 2021 -0400 +++ b/mercurial/extensions.py Mon Sep 20 14:16:10 2021 -0400 @@ -224,8 +224,12 @@ minver = getattr(mod, 'minimumhgversion', None) if minver: curver = util.versiontuple(n=2) + extmin = util.versiontuple(minver, 2) - if None in curver or util.versiontuple(minver, 2) > curver: + if None in extmin: + extmin = (extmin[0] or 0, extmin[1] or 0) + + if None in curver or extmin > curver: msg = _( b'(third party extension %s requires version %s or newer ' b'of Mercurial (current: %s); disabling)\n'