diff hgext/mq.py @ 28388:b1d35e2e1af6 stable

mq: restrict generated patch name to 75 characters (issue5117) Super long first line in description lead to very long file name that windows is unhappy about. We restrict the name to 75 char to avoid the issue. 75 seems fine and leave some extra room for '__#' suffix in case of conflict. I does not seems worthwhile to add a dedicated config option to configure the length. It can be done in the future if there is an actual user demand for it.
author Pierre-Yves David <pierre-yves.david@fb.com>
date Wed, 09 Mar 2016 22:21:08 +0000
parents db24d6888896
children 3072ce740945
line wrap: on
line diff
--- a/hgext/mq.py	Sun Mar 06 14:30:34 2016 -0500
+++ b/hgext/mq.py	Wed Mar 09 22:21:08 2016 +0000
@@ -1117,6 +1117,7 @@
         """Return a suitable filename for title, adding a suffix to make
         it unique in the existing list"""
         namebase = re.sub('[\s\W_]+', '_', title.lower()).strip('_')
+        namebase = namebase[:75] # avoid too long name (issue5117)
         if namebase:
             try:
                 self.checkreservedname(namebase)