diff mercurial/revlogutils/deltas.py @ 39793:b63dee7bd0d9

global: replace most uses of RevlogError with StorageError (API)

When catching errors in storage, we should be catching
StorageError instead of RevlogError. When throwing errors related
to storage, we shouldn't be using RevlogError unless we know
the error stemmed from revlogs. And we only reliably know that
if we're in revlog.py or are inheriting from a type defined in
revlog.py.

Differential Revision: https://phab.mercurial-scm.org/D4655

--- a/mercurial/revlogutils/deltas.py	Tue Sep 18 16:45:13 2018 -0700
+++ b/mercurial/revlogutils/deltas.py	Tue Sep 18 16:47:09 2018 -0700
@@ -457,7 +457,8 @@
         if validatehash:
             revlog.checkhash(fulltext, expectednode, p1=p1, p2=p2)
         if flags & REVIDX_ISCENSORED:
-            raise error.RevlogError(_('node %s is not censored') % expectednode)
+            raise error.StorageError(_('node %s is not censored') %
+                                     expectednode)
     except error.CensoredNodeError:
         # must pass the censored index flag to add censored revisions
         if not flags & REVIDX_ISCENSORED: