Mercurial > hg-stable
diff mercurial/cext/bdiff.c @ 37873:d9e87566f879 stable
cext: stop worrying and love the free(NULL)
There is no need to check for a NULL pointer before calling free since
free(NULL) is defined by C standards as a no-op. Lots of software relies on
this behavior so it is completely safe to call even on the most obscure of
systems.
author | Josef 'Jeff' Sipek <jeffpc@josefsipek.net> |
---|---|
date | Wed, 13 Jun 2018 10:37:39 -0400 |
parents | 273ea09f6550 |
children | 93b812d5b818 |
line wrap: on
line diff
--- a/mercurial/cext/bdiff.c Sun May 20 23:05:18 2018 -0400 +++ b/mercurial/cext/bdiff.c Wed Jun 13 10:37:39 2018 -0400 @@ -155,12 +155,8 @@ PyEval_RestoreThread(_save); PyBuffer_Release(&ba); PyBuffer_Release(&bb); - if (al) { - free(al); - } - if (bl) { - free(bl); - } + free(al); + free(bl); if (l.next) { bdiff_freehunks(l.next); }