diff contrib/chg/hgclient.c @ 30726:dd897eb1699e

chg: send type information via S channel (BC) Previously S channel is only used to send system commands. It will also be used to send pager commands. So add a type parameter. This breaks older chg clients. But chg and hg should always come from a single commit and be packed into a single package. Supporting running inconsistent versions of chg and hg seems to be unnecessarily complicated with little benefit. So just make the change and assume people won't use inconsistent chg with hg.
author Jun Wu <quark@fb.com>
date Fri, 06 Jan 2017 16:11:03 +0000
parents fe11f466880d
children 7438cb35979a
line wrap: on
line diff
--- a/contrib/chg/hgclient.c	Sun Jan 01 13:16:29 2017 +0100
+++ b/contrib/chg/hgclient.c	Fri Jan 06 16:11:03 2017 +0000
@@ -237,10 +237,10 @@
 	ctx->data[ctx->datasize] = '\0';  /* terminate last string */
 
 	const char **args = unpackcmdargsnul(ctx);
-	if (!args[0] || !args[1])
-		abortmsg("missing command or cwd in system request");
-	debugmsg("run '%s' at '%s'", args[0], args[1]);
-	int32_t r = runshellcmd(args[0], args + 2, args[1]);
+	if (!args[0] || !args[1] || !args[2])
+		abortmsg("missing type or command or cwd in system request");
+	debugmsg("run '%s' at '%s'", args[1], args[2]);
+	int32_t r = runshellcmd(args[1], args + 3, args[2]);
 	free(args);
 
 	uint32_t r_n = htonl(r);