Mercurial > hg-stable

diff hgext/bugzilla.py @ 16876:fdc879042414 stable

Find changesets by keywords (author, files, the commit message), revision number or hash, or revset expression.
bugzilla: stop bugs always being marked as fixed in xmlrpc (issue3484) Bugs should only be marked fixed if the comment parser gives them the fixed state. xmlrpc+email got this right, xmlrpc screwed it up.
author Jim Hague <jim.hague@acm.org>
date Wed, 06 Jun 2012 16:44:17 +0100
parents 822e75386c16
children 2255950e1f76
line wrap: on
line diff
--- a/hgext/bugzilla.py	Mon Jun 04 17:22:09 2012 -0500
+++ b/hgext/bugzilla.py	Wed Jun 06 16:44:17 2012 +0100
@@ -654,8 +654,9 @@
         if self.bzvermajor >= 4:
             args['ids'] = [bugid]
             args['comment'] = {'body' : text}
-            args['status'] = self.fixstatus
-            args['resolution'] = self.fixresolution
+            if 'fix' in newstate:
+                args['status'] = self.fixstatus
+                args['resolution'] = self.fixresolution
             self.bzproxy.Bug.update(args)
         else:
             if 'fix' in newstate: