Mercurial > hg-stable
view contrib/fuzz/fuzzutil.cc @ 40479:197f092b2cd9 stable 4.8.2
server: always close http socket if responding with an error (issue6033)
It's possible for hgweb to respond _very_ early with an error if we're
catching certain types of errors. When we do, we need to tell the client
the socket is toast when there's a POST involved because otherwise there
can be lingering POST data on the socket that will confuse any future
requests on the socket. This manifested as a flaky failure on Linux in an
lfs extension test and a reliable failure on FreeBSD. With this patch
applied, test-lfs-serve-access.t now passes for me on FreeBSD.
Differential Revision: https://phab.mercurial-scm.org/D5498
author | Augie Fackler <raf@durin42.com> |
---|---|
date | Sun, 06 Jan 2019 14:58:54 -0500 |
parents | a1c0873a9990 |
children |
line wrap: on
line source
#include "fuzzutil.h" #include <cstring> #include <utility> contrib::optional<two_inputs> SplitInputs(const uint8_t *Data, size_t Size) { if (!Size) { return contrib::nullopt; } // figure out a random point in [0, Size] to split our input. size_t left_size = (Data[0] / 255.0) * (Size - 1); // Copy inputs to new allocations so if bdiff over-reads // AddressSanitizer can detect it. std::unique_ptr<char[]> left(new char[left_size]); std::memcpy(left.get(), Data + 1, left_size); // right starts at the next byte after left ends size_t right_size = Size - (left_size + 1); std::unique_ptr<char[]> right(new char[right_size]); std::memcpy(right.get(), Data + 1 + left_size, right_size); LOG(2) << "inputs are " << left_size << " and " << right_size << " bytes" << std::endl; two_inputs result = {std::move(right), right_size, std::move(left), left_size}; return result; }