convert/darcs: handle non-ASCII metadata in darcs changelog (issue2354)
Given a commit author or message with non-ASCII characters in a darcs
repo, convert would raise a UnicodeEncodeError when adding changesets
to the hg changelog.
This happened because etree returns back unicode objects for any text
it can't encode into ASCII. convert was passing these objects to
changelog.add(), which would then attempt encoding.fromlocal() on
them.
This patch ensures converter_source.recode() is called on each piece
of commit data returned by etree.
(Also note that darcs is currently encoding agnostic and will print
out whatever is in a patch's metadata byte-for-byte, even in the XML
changelog.)
#!/bin/sh
echo % test --time
hg --time help -q help 2>&1 | grep Time > /dev/null || echo --time failed
hg init a
cd a
echo % test --profile
if "$TESTDIR/hghave" -q lsprof; then
hg --profile st 2>../out || echo --profile failed
grep CallCount < ../out > /dev/null || echo wrong --profile
hg --profile --config profiling.output=../out st 2>&1 \
|| echo --profile + output to file failed
grep CallCount < ../out > /dev/null \
|| echo wrong --profile output when saving to a file
hg --profile --config profiling.format=text st 2>&1 \
| grep CallCount > /dev/null || echo --profile format=text failed
echo "[profiling]" >> $HGRCPATH
echo "format=kcachegrind" >> $HGRCPATH
hg --profile st 2>../out || echo --profile format=kcachegrind failed
grep 'events: Ticks' < ../out > /dev/null || echo --profile output is wrong
hg --profile --config profiling.output=../out st 2>&1 \
|| echo --profile format=kcachegrind + output to file failed
grep 'events: Ticks' < ../out > /dev/null \
|| echo --profile output is wrong
fi