hgext/inotify/client.py

inotify: dic.setdefault(k, d) ; v = dic[k] --> v = dic.setdefault(k, d)

dict.setdefault sets a default value, but also returns the dict.get result.
Getting the value on the next instruction was redundant.

# client.py - inotify status client
#
# Copyright 2006, 2007, 2008 Bryan O'Sullivan <[e-mail]>
# Copyright 2007, 2008 Brendan Cully <[e-mail]>
#
# This software may be used and distributed according to the terms of the
# GNU General Public License version 2, incorporated herein by reference.

from mercurial.i18n import _
import common
import os, socket, struct

def query(ui, repo, names, match, ignored, clean, unknown=True):
    sock = socket.socket(socket.AF_UNIX)
    sockpath = repo.join('inotify.sock')
    try:
        sock.connect(sockpath)
    except socket.error, err:
        if err[0] == "AF_UNIX path too long":
            sockpath = os.readlink(sockpath)
            sock.connect(sockpath)
        else:
            raise

    def genquery():
        for n in names:
            yield n
        states = 'almrx!'
        if ignored:
            raise ValueError('this is insanity')
        if clean: states += 'c'
        if unknown: states += '?'
        yield states

    req = '\0'.join(genquery())

    sock.sendall(chr(common.version))
    sock.sendall(req)
    sock.shutdown(socket.SHUT_WR)

    cs = common.recvcs(sock)
    version = ord(cs.read(1))

    if version != common.version:
        ui.warn(_('(inotify: received response from incompatible server '
                  'version %d)\n') % version)
        return None

    try:
        resphdr = struct.unpack(common.resphdrfmt, cs.read(common.resphdrsize))
    except struct.error:
        return None

    def readnames(nbytes):
        if nbytes:
            names = cs.read(nbytes)
            if names:
                return filter(match, names.split('\0'))
        return []

    return map(readnames, resphdr)