check-code: catch Python 'is' comparing number or string literals
The Python 'is' operator compares object identity, so it should
definitely not be applied to string or number literals, which Python
implementations are free to represent with a temporary object.
This should catch the following kinds of bogus expressions (examples):
x is 'foo' x is not 'foo'
x is "bar" x is not "bar"
x is 42 x is not 42
x is -36 x is not -36
As originally proposed by Martin Geisler, amended with catching
negative numbers.
$ "$TESTDIR/hghave" inotify || exit 80
$ echo "[extensions]" >> $HGRCPATH
$ echo "inotify=" >> $HGRCPATH
$ p="xxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxx"
$ hg init $p
$ cd $p
fail
$ ln -sf doesnotexist .hg/inotify.sock
$ hg st
abort: inotify-server: cannot start: .hg/inotify.sock is a broken symlink
inotify-client: could not start inotify server: child process failed to start
$ hg inserve
abort: inotify-server: cannot start: .hg/inotify.sock is a broken symlink
[255]
$ rm .hg/inotify.sock
inserve
$ hg inserve -d --pid-file=hg.pid
$ cat hg.pid >> "$DAEMON_PIDS"
status
$ hg status
? hg.pid
if we try to start twice the server, make sure we get a correct error
$ hg inserve -d --pid-file=hg2.pid
abort: inotify-server: cannot start: socket is already bound
abort: child process failed to start
[255]
$ kill `cat hg.pid`