localrepo.commit: grab locks before getting the list of files to commit
Somebody may change the dirstate after we've determined the parents of
the working dir and run repo.status, but before we called wlock().
This should also fix issue997, where backout would change a file without
changing its size and then call repo.commit without passing the list of
files. If this happened in less than one second, we wouldn't detect any
file changes - the in-memory dirstate still has the cached stat data for
that file. Grabbing the wlock early causes the dirstate to be
invalidated and we end up reading the dirstate file again, which has
that file marked for lookup (size == -1).
A better fix would be for backout to give repo.commit the exact list of
files, but that'll require some changes to the revert operation.
A significant user-visible change is that the precommit hook is always
run with both locks grabbed - previously, hg commit would run it before
grabbing any locks, but hg import would run it after grabbing locks.
0 files updated, 0 files merged, 1 files removed, 0 files unresolved
Main should be gone
a
created new head
changeset: 3:ded32b0db104
tag: tip
user: test
date: Mon Jan 12 13:46:40 1970 +0000
summary: Added side2
changeset: 2:92a816cea698
parent: 0:537353581d3d
user: test
date: Mon Jan 12 13:46:40 1970 +0000
summary: Added side1
changeset: 1:221226fb2bd8
user: test
date: Mon Jan 12 13:46:40 1970 +0000
summary: Added main
changeset: 0:537353581d3d
user: test
date: Mon Jan 12 13:46:40 1970 +0000
summary: Added a
Should have two heads, side2 and main
changeset: 3:ded32b0db104
tag: tip
user: test
date: Mon Jan 12 13:46:40 1970 +0000
summary: Added side2
changeset: 1:221226fb2bd8
user: test
date: Mon Jan 12 13:46:40 1970 +0000
summary: Added main
Should show a side1 side2
a
side1
side2
resolving manifests
overwrite True partial False
ancestor 537353581d3d local ded32b0db104+ remote 221226fb2bd8
side2: remote deleted -> r
side1: remote deleted -> r
main: remote created -> g
getting main
removing side1
removing side2
1 files updated, 0 files merged, 2 files removed, 0 files unresolved
Should only show a main
a
main