view .gitlab/merge_request_templates/Default.md @ 51918:d62887764687

lfs: fix various signature mismatches for vfs subclasses

These were flagged by PyCharm.  I'm not sure why pytype doesn't catch these-
only `hgext/lfs/__init__.py` in the lfs extension is excluded from being
checked.

I'm not sure if the `*insidef` arg to `join()` was meant as an internal
convencience, because I see another class that gets flagged for the same
signature problem (to be fixed next).  But I don't feel bold enough to make this
an internal function, and provide a simplified public `join()` on the `vfs`
classes.  That can still be done later, if desired.  For now, process the
additional args and pass them along, even though there don't appear to be any
current callers that provide extra args to these classes.  We need all of the
subclasses to agree on the signature, or they won't be considered to implement
the `Vfs` protocol being developed.

While we're copy/pasting from the base class, bring the type annotations along
for the ride.

/assign_reviewer @mercurial.review


<!--

Welcome to the Mercurial Merge Request creation process:

* Set a simple title for your MR,
* All important information should be contained in your changesets' content or description,
* You can add some workflow-relevant information here (eg: when this depends on another MR),
* If your changes are not ready for review yet, click `Start the title with Draft:` under the title.

More details here:

* https://www.mercurial-scm.org/wiki/ContributingChanges
* https://www.mercurial-scm.org/wiki/Heptapod

-->