view CONTRIBUTING @ 51918:d62887764687

lfs: fix various signature mismatches for vfs subclasses

These were flagged by PyCharm.  I'm not sure why pytype doesn't catch these-
only `hgext/lfs/__init__.py` in the lfs extension is excluded from being
checked.

I'm not sure if the `*insidef` arg to `join()` was meant as an internal
convencience, because I see another class that gets flagged for the same
signature problem (to be fixed next).  But I don't feel bold enough to make this
an internal function, and provide a simplified public `join()` on the `vfs`
classes.  That can still be done later, if desired.  For now, process the
additional args and pass them along, even though there don't appear to be any
current callers that provide extra args to these classes.  We need all of the
subclasses to agree on the signature, or they won't be considered to implement
the `Vfs` protocol being developed.

While we're copy/pasting from the base class, bring the type annotations along
for the ride.

Our full contribution guidelines are in our wiki, please see:

https://www.mercurial-scm.org/wiki/ContributingChanges

If you just want a checklist to follow, you can go straight to

https://www.mercurial-scm.org/wiki/ContributingChanges#Submission_checklist

If you can't run the entire testsuite for some reason (it can be
difficult on Windows), please at least run `contrib/check-code.py` on
any files you've modified and run `python contrib/check-commit` on any
commits you've made (for example, `python contrib/check-commit
273ce12ad8f1` will report some style violations on a very old commit).