view tests/test-convert-bzr-directories.out @ 12592:f2937d6492c5 stable

url: verify correctness of https server certificates (issue2407)

Pythons SSL module verifies that certificates received for HTTPS are valid
according to the specified cacerts, but it doesn't verify that the certificate
is for the host we connect to.

We now explicitly verify that the commonName in the received certificate
matches the requested hostname and is valid for the time being.

This is a minimal patch where we try to fail to the safe side, but we do still
rely on Python's SSL functionality and do not try to implement the standards
fully and correctly. CRLs and subjectAltName are not handled and proxies
haven't been considered.

This change might break connections to some sites if cacerts is specified and
the certificates (by our definition) isn't correct. The workaround is to
disable cacerts which in most cases isn't much worse than it was before with
cacerts.

% empty directory
initializing destination source-hg repository
scanning source...
sorting...
converting...
2 Initial add
1 Empty directory added
0 Added file into directory
% manifest of 1
644   a
% manifest of tip
644   a
644   empty/something
% directory renames
tpyo => typo
initializing destination source-hg repository
scanning source...
sorting...
converting...
1 Added directory
0 Oops, typo
% manifest of 0
644   tpyo/something
% manifest of tip
644   typo/something
% nested directory renames
firstlevel/secondlevel => secondlevel
initializing destination source-hg repository
scanning source...
sorting...
converting...
1 Added nested directories
0 Moved secondlevel one level up
% manifest of tip
644   secondlevel/file
644   secondlevel/thirdlevel/stuff
% directory remove
initializing destination source-hg repository
scanning source...
sorting...
converting...
1 Added directory
0 Removed directory
% manifest of 0
644   src/sourcecode
% manifest of tip
% directory replace
first/file => second/file
first => third
initializing destination source-hg repository
scanning source...
sorting...
converting...
1 Initial layout
0 Some conflicting moves
% manifest of tip
644   second/file
644   second/something
644   third/dummy