view tests/test-share.out @ 12592:f2937d6492c5 stable

url: verify correctness of https server certificates (issue2407)

Pythons SSL module verifies that certificates received for HTTPS are valid
according to the specified cacerts, but it doesn't verify that the certificate
is for the host we connect to.

We now explicitly verify that the commonName in the received certificate
matches the requested hostname and is valid for the time being.

This is a minimal patch where we try to fail to the safe side, but we do still
rely on Python's SSL functionality and do not try to implement the standards
fully and correctly. CRLs and subjectAltName are not handled and proxies
haven't been considered.

This change might break connections to some sites if cacerts is specified and
the certificates (by our definition) isn't correct. The workaround is to
disable cacerts which in most cases isn't much worse than it was before with
cacerts.

% prepare repo1
adding a
% share it
updating working directory
1 files updated, 0 files merged, 0 files removed, 0 files unresolved
% contents of repo2/.hg
pass: .hg/store does not exist
$HGTMP/test-share/repo1/.hg
% commit in shared clone
% check original
changeset:   1:8af4dc49db9e
tag:         tip
user:        test
date:        Thu Jan 01 00:00:00 1970 +0000
summary:     change in shared clone

changeset:   0:d3873e73d99e
user:        test
date:        Thu Jan 01 00:00:00 1970 +0000
summary:     init

1 files updated, 0 files merged, 0 files removed, 0 files unresolved
a
a
% commit in original
adding b
% check in shared clone
changeset:   2:c2e0ac586386
tag:         tip
user:        test
date:        Thu Jan 01 00:00:00 1970 +0000
summary:     another file

changeset:   1:8af4dc49db9e
user:        test
date:        Thu Jan 01 00:00:00 1970 +0000
summary:     change in shared clone

changeset:   0:d3873e73d99e
user:        test
date:        Thu Jan 01 00:00:00 1970 +0000
summary:     init

1 files updated, 0 files merged, 0 files removed, 0 files unresolved
b
% hg serve shared clone
200 Script output follows


-rw-r--r-- 4 a
-rw-r--r-- 2 b