Gregory Szorc <gregory.szorc@gmail.com> [Sat, 27 Feb 2016 21:43:17 -0800] rev 28292
worker: document poor partitioning scheme impact
mpm isn't a fan of the existing or previous partitioning scheme. He
provided a fantastic justification for why on the mailing list.
This patch adds his words to the code so they aren't forgotten.
Matt Mackall <mpm@selenic.com> [Tue, 01 Mar 2016 18:03:49 -0600] rev 28291
Added signature for changeset d493d64757eb
Matt Mackall <mpm@selenic.com> [Tue, 01 Mar 2016 18:03:44 -0600] rev 28290
Added tag 3.7.2 for changeset d493d64757eb
Gregory Szorc <gregory.szorc@gmail.com> [Sat, 27 Feb 2016 18:22:49 -0800] rev 28289
hg: obtain lock when creating share from pooled repo (issue5104)
There are race conditions between clients performing a shared clone
to pooled storage:
1) Clients race to create the new shared repo in the pool directory
2) 1 client is seeding the repo in the pool directory and another goes
to share it before it is fully cloned
We prevent these race conditions by obtaining a lock in the pool
directory that is derived from the name of the repo we will be
accessing.
To test this, a simple generic "lockdelay" extension has been added.
The extension inserts an optional, configurable delay before or after
lock acquisition. In the test, we delay 2 seconds after lock acquisition
in the first process and 1 second before lock acquisition in the 2nd
process. This means the first process has 1s to obtain the lock. There
is a race condition here. If we encounter it in the wild, we could
change the dummy extension to wait on the lock file to appear instead
of relying on timing. But that's more complicated. Let's see what
happens first.