revlog: document the `update_caches` method A small docstring does not hurt.

revlog: make the `candelta` method private It is only used internally, so lets make it clear.

revlog: document the `get_streams` method A small docstring does not hurt.

revlog: document the `is_inline_index` method A small docstring does not hurt.

opemvms: add specific files and utilities

openvms: do not check for shebang in openvms script It does not apply to them.

openvms: consider worker costly on OpenVMS As for Windows, the parallel worker feature is less appealing on OpenVMS.

openvms: fix the pager spawning and cleanup Unsurprisingly, pager handling needs some adjustment.

openvms: make process spawning works on OpenVMS We need to adjust some behavior for OpenVMS.

openvms: mark symlink as unsupported on OpenVMS OpenVMS's symlink emulation is broken on some OpenVMS versions, so we better disable them altogether for now.

openvms: duck-punch a bugfix into `environb` object The official Python3 build for OpenVMS has some crippling bug that we need to patch dynamically OpenVMS patches

fastexport: simplify code

branching: merge stable into default

admin-command: add verify command Start using the 'admin' namespace by adding a 'verify' command. Invocation is 'admin::verify'. The idea is to progressively add more focused checks than the existing verify command. To do so we need an advanced way to express what we want to check. The first check for admin::verify is 'working-copy.dirstate' which has no options, because it was an easy first check to implement, which verifies the integrity of the dirstate. This changeset was created with the help of Franck Bret.

transaction: abstract away the detection of an abandoned transaction We're about to add another place where this is used, let's not spill this implementation detail.

commands: add admin namespace In order to stop abusing the 'debug' namespace for non-debug command, it adds a new 'admin' namespace dedicated to 'admin' operations on a repository (i.e commands suitable for administration tasks). This namespace entry would be used to migrate in the future some existing commands from the 'debug' namespace, or other top level commands that may not be directly exposed to end users. (verify command is a perfect candidate for this case)

rust-config: fix incorrect coercion of null values to false As explained in the previous changeset: Probably being too trigger happy about boolean values, I incorrectly set the transform for a `None` to a `Some(false)`. It would cause for example the `ui.formatted` value to be set to `Some(false)`, which turns off the colors among other things, when `None` would trigger the automatic behavior.

rust-config: show default `null` is coerced incorrectly to `false` Probably being too trigger happy about boolean values, I incorrectly set the transform for a `None` to a `Some(false)`. It would cause for example the `ui.formatted` value to be set to `Some(false)`, which turns off the colors among other things, when `None` would trigger the automatic behavior. This is fixed in the next commit.

rust-config: fix fallback to default not parsing the default value When a config item's default is a string, it sometimes needs to be parsed into another type, like in the case of `cmdserver.max-log-size`, that returns a number of bytes from a human-readable amount like `25MB`. The logic for the fix is explained inline.

rust-config: demonstrate a bug when falling back to non-trivial default values The default value (when the user hasn't configured anything) is not run through the value parser, causing a programming error to happen because of type mismatch. This will be fixed in the next commit.

rust: make `Revision` a newtype This change is the one we've been building towards during this series. The aim is to make `Revision` mean more than a simple integer, holding the information that it is valid for a given revlog index. While this still allows for programmer error, since creating a revision directly and querying a different index with a "checked" revision are still possible, the friction created by the newtype will hopefully make us think twice about which type to use. Enough of the Rust ecosystem relies on the newtype pattern to be efficiently optimized away (even compiler in codegen tests¹), so I'm not worried about this being a fundamental problem. [1] https://github.com/rust-lang/rust/blob/7a70647f195f6b0a0f1ebd72b1542ba91a32f43a/tests/codegen/vec-in-place.rs#L47

rust: implement the `Graph` trait for all revlogs This is trivial and makes all the algorithms relying on the trait usable for more use cases.

rust: use the new `UncheckedRevision` everywhere applicable This step converts all revisions that shouldn't be considered "valid" in any context to `UncheckedRevison`, allowing `Revision` to be changed for a stronger type in a later changeset. Note that the conversion from unchecked to checked is manual and requires at least some thought from the programmer, although directly using `Revision` is still possible. A later changeset will make this mistake harder to make.

rust-revlog: split logic for `rawdata` to prepare for `UncheckedRevision` use In the next changeset, we will change the logic to use `UncheckedRevision` in the non-general delta case. The general delta case will use the "checked" path since `base_rev_or_base_of_delta_chain` will be checked.

rust: remove unused error variant All paths check that the working directory revision is not used.

rust: add `UncheckedRevision` type This is the start of a series whose aim is to separate "checked" and "unchecked" revision numbers. A "checked" revision number is valid for a given index, allowing us to have faster algorithms that don't do redundant checks all the time and have a clearer view of the kinds of revisions we're working with.

debugwireproto: migrate `opts` to native kwargs

debugwireargs: migrate `opts` to native kwargs

debugwalk: migrate `opts` to native kwargs

debug_revlog_stats: migrate `opts` to native kwargs

debugbackupbundle: migrate `opts` to native kwargs

debugsidedata: migrate `opts` to native kwargs

debugserve: migrate `opts` to native kwargs

debugrevspec: migrate `opts` to native kwargs

debugrevlogindex: migrate `opts` to native kwargs

debugrevlog: migrate `opts` to native kwargs

debugrename: migrate `opts` to native kwargs

debugrebuildfncache: migrate `opts` to native kwargs

debugpickmergetool: migrate `opts` to native kwargs

debugp2copies: migrate `opts` to native kwargs

debugp1copies: migrate `opts` to native kwargs

debugobsolete: migrate `opts` to native kwargs

debugmergestate: migrate `opts` to native kwargs

debugknown: migrate `opts` to native kwargs

debuginstall: migrate `opts` to native kwargs

debugindexdot: migrate `opts` to native kwargs

debuggetbundle: migrate `opts` to native kwargs

debugformat: migrate `opts` to native kwargs

debugfileset: migrate `opts` to native kwargs

debugextensions: migrate `opts` to native kwargs

debugdiscovery: migrate `opts` to native kwargs

debugdeltafind: migrate `opts` to native kwargs

debugdeltachain: migrate `opts` to native kwargs

debugdata: migrate `opts` to native kwargs

debugcapabilities: migrate `opts` to native kwargs

debugbundle: migrate `opts` to native kwargs This is a utility function that's only called by `debugbundle()`. The rest of the command was previously ported.

branching: merge with stable

branching: merge stable into default

pycompat: drop usage of hasattr/getattr/setattr/delatt proxy The function remains to ease extensions transition, but we no longer use them in core.

safehasattr: drop usage in favor of hasattr The two functions should now be equivalent at least in their usage in core.

check-code: drop the `safehasattr` rule Since we no longer supports Python 2 we no longer needs to use a custom function to compensate the short comings of the global `hasattr` function in it. We cannot use the Python 3 `hasattr` function instead.

url: ignore some future pytype error As soon as we start using the builtins `hasattr` function, pytype will start getting confused about which types are available or not. So we ignore this error beforehand.

url: move the _generic_proxytunnel in the `has_https` block It is only used when https exists. If you stay out of the block, pytype complains that the type of its argument are not declared.

pycompat: deprecate using bytes Python2 has been dropped for a while, so lets comply to the signature of the global function. This open the way to drop the use of `pycompat.getattr` and company, and, especially, the associated `util.safehasattr`.

dynamic-import: use sysstr for importing extension and others This logic is used by extensions, and python hooks and merge-tools. All this logic eventually deals with native string (unicode in Python 3). This patch makes it handle `str` directly instead of relying on some pycompat low lever layer to do the conversion at the last minutes. We adjust the Python version filtering of a test as the output seems to be present with Python 3.7 too.

extension: check the command attributes using `sysstr` Since we are checking attributes, lets use the native representation instead of bytes.

extension: access special module members using sysstr These extensions variables and mapping are module attributes so they should be dealt with unicode `str` in Python 3. We move the part that deal with reading theses variable and checking their validity to use unicode `str` string.

sshpeer: convert command name to sysstr before accessing method Method name are `str` so we should pass them as `str`.

localrepo: purge filecache attribute using there unicode name This could be better, but that's a good step.

fastannotate: use sysstr to check for attribute presence We do not need bytes here.

fastannotate: use sysstr to deal with some attributes We are now Python3 only and attribute are always unicode string. So no needs to managed them using bytes.

hgweb: use sysstr to set attribute on diff option Attribute identifier should be `str` not `bytes`.

hgweb: use sysstr to get attribute on diff option Attribute identifier should be `str` not `bytes`.

diff-option: move attributes handling to sysstr Attributes are `str` and should be handled as such.

compression: use sysstr to specify attribute to fetch for priority These are attributes so they should be `str`.

smartset: set attribute using sysstr instead of bytes We do not needs bytes here.

cachedlocalrepo: use sysstr for attribute name of "file of interest" The first item is an attribute name, the second one is a filename. So the first one can (and should) be a `str`.

terse-status: use `sysstr` to specify attributes to set We use unicode string to specify attribute and we add a explicit char for the other usage.

path-suboption: deprecated specifying the attributes as bytes The known suboptions have been updated, so we can deprecated passing bytes in case some extensions use them.

path-suboption: use str for "_pushloc" suboptions That second argument refer to an attribute and do not needs to be bytes.

path-suboption: use str for "pushrev" suboptions That second argument refer to an attribute and do not needs to be bytes.

path-suboption: use str for "bookmarks_mode" suboptions That second argument refer to an attribute and do not needs to be bytes.

path-suboption: use str for "delta_reuse_policy" suboptions That second argument refer to an attribute and do not needs to be bytes.

path-suboption: use str for "multi_urls" path suboptions That second argument refer to an attribute and do not needs to be bytes.

convert: use sysstr to check for attribute presence We do not need bytes here.

mq: use sysstr to check for attribute access We do not need bytes here.

lfs: use sysstr to check for attribute presence We do not need bytes here.

mq: use sysstr to check for attribute presence We do not need bytes here.

relink: use sysstr to check for attribute presence We do not need bytes here.

ui: use sysstr to check for attribute presence We do not need bytes here.

remotefilelog: use sysstr to access for attributes We do not need bytes here.

hgwebmod: use sysstr to check for attribute presence We do not need bytes here.

remotefilelog: use sysstr to check for attribute presence We do not need bytes here.

extensions: use sysstr to check for attribute presence We do not need bytes here.

bundle2: use sysstr to check for attribute presence We do not need bytes here.

largefile: use sysstr to check for attribute presence in `hgsubrepoarchive` We do not need bytes here.

largefile: use sysstr to check for attribute presence in `openstore` We do not need bytes here.

largefile: use sysstr to check for attribute presence in `rebase` wrapping We do not need bytes here.

largefile: use sysstr to check for attribute presence in `getstatuswriter` We do not need bytes here.

run-tests: detect HGWITHRUSTEXT value Without this, some manual check in tests/test-dirstate.t could get confused by the lack of `rust` in module policy and break the test.

convert: stabilize subversion date sorter In case of tie, this provides unstable result on my system. So I am adding a couple of tie breaker to fix the test.

rhg: allow setting defaults.cmd to an empty string This is used by at least one hg UI to prevent defaults from affecting the command: https://github.com/emacs-mirror/emacs/blob/b71beb7ae7c60a5c5af608420d28fdda5265a264/lisp/vc/vc-hg.el#L245 Let's let it work.

uncommit: migrate `opts` to native kwargs

split: migrate `opts` to native kwargs

releasenotes: migrate `opts` to native kwargs

narrow: hoist a variable to a higher level to avoid use-before-init warning In practice, this shouldn't generate an IOError, so there wouldn't have been a problem. But PyCharm didn't know that.

narrow: migrate `opts` to native kwargs

largefiles: migrate `opts` to native kwargs

keyword: migrate `opts` to native kwargs

gpg: use a context manager to write `.hgsigs`

gpg: migrate `opts` to native kwargs

fetch: migrate `opts` to native kwargs

fastexport: migrate `opts` to native kwargs

closehead: wrap transaction handling in a context manager

closehead: migrate `opts` to native kwargs

churn: migrate `opts` to native kwargs

children: migrate `opts` to native kwargs

automv: migrate `opts` to native kwargs

absorb: migrate `opts` to native kwargs

rhg: support rhg files [FILE] This comes mostly for free after the rhg status [FILE] implementation.

rhg: support "status FILE" This change adds a new [file] argument to rhg status, parses them as patterns, canonicalizes the paths, and constructs a new PatternMatcher to intersect with the existing matcher being passed to the status implementation. We also make filepatterns a public module so we can access the pattern-parsing functionality we need from commands/status.rs.

rust-matchers: add PatternMatcher This should match the behavior of the Python patternmatcher. We need this for status [FILES] support.

rust-status: only visit parts of the tree requested by the matcher This is an optimization that the matcher is designed to support, but we weren't doing it until now. This is primarily relevant for supporting "hg status [FILES]", where this optimization is crucial for getting good performance (without this optimization, that command will still scan the entire tree, and just filter it down after the fact). When this optimization fires we have to return false from traverse_fs_directory_and_dirstate, representing that that part of the tree *might* have new files which we didn't see because we skipped parts of it. This only affects the cached result of the status, and is necessary to make future status operations (which might use a different matcher) work properly.

rust-status: error on non-existent files in file_set file_set here consists of the files that were explicitly specified on the command line. Erroring on them matches the behavior of Python status.

rust-status: explicitly track bad file types Before this, we silently skipped bad file types. Now, we check to see if a path is an exact_match in our matcher, and if so, print an error for it, and only then do we skip it. A path will be an exact match when it's specified as an explicit command line argument, and this error-printing behavior is necessary for compatibility with Python status.

rust: de-hardcode glob_suffix We're adding patternmatcher in a subsequent commit, and this needs needs to be different for includematcher and patternmatcher.

rust: improve the type on DirsMultiset::from_manifest It could only return an HgPathError, but we didn't express this in the type, so we needed some unreachable!()s. Now that is expressed in the type.

rust: don't escape spaces in regex Spaces are not in fact a regex special character, and escaping them is not correct.

rust-filepatterns: also normalize RelPath These patterns should be normalized too; this at least does no harm, and is necessary for proper status support.

rust: simplify pattern file parsing Previously we kept the pattern syntax as a &[u8] until the last possible moment, which meant we had to handle potential errors when parsing that &[u8]. But such errors could never actually occur, given the structure of the code. Now we parse it eagerly (in two places) and pass it around as a PatternSyntax, so we can delete some error handling code. parse_one_pattern is in particular useful for parsing patterns passed on the command line, as we'll support later in this series.

rust-matchers: better support file_set in IntersectionMatcher Previously, if both of the input matchers had non-exact file sets, IntersectionMatcher would simply have an empty fileset. Now, we duplicate Python behavior: we *union* the filesets of the matchers in that case. This makes some sense, because without exact input file sets, we can't do an exact intersection and must over-approximate. Concretely, this is necessary because the file_set is the list of files that were explicitly listed by the user, and we want to provide explicit errors for all such files, from both matchers.

branching: merge stable into default

version: migrate `opts` to native kwargs

verify: migrate `opts` to native kwargs

tags: migrate `opts` to native kwargs

tag: migrate `opts` to native kwargs

summary: migrate `opts` to native kwargs This has the added benefit of unconfusing PyCharm- it thought `opts` in the nested functions were str based for some reason.

revert: migrate `opts` to native kwargs

rename: drop an unnecessary variable declaration at a wider scope

rename: migrate `opts` to native kwargs

remove: migrate `opts` to native kwargs

purge: migrate `opts` to native kwargs

pull: avoid referencing a variable before it is initialized If `urlutil.get_pull_paths()` somehow yields nothing, the reference after the loop appears to be a problem. I noticed this because PyCharm flagged (and still flags) the initialization of this inside the loop as somehow unused. I'm not sure why 1 isn't returned directly where it is set to the result of `postincoming()`, but maybe the code is structured this way in anticipation of future work.

pull: migrate `opts` to native kwargs

paths: migrate `opts` to native kwargs

merge: migrate `opts` to native kwargs

manifest: migrate `opts` to native kwargs

locate: migrate `opts` to native kwargs

import: migrate `opts` to native kwargs

heads: migrate `opts` to native kwargs

forget: migrate `opts` to native kwargs

copy: drop an unused variable

copy: migrate `opts` to native kwargs

config: use the writefile() utility to create the sample hgrc This function uses a context manager.

config: migrate `opts` to native kwargs

clone: migrate `opts` to native kwargs

bundle: migrate `opts` to native kwargs

branches: migrate `opts` to native kwargs

branch: migrate `opts` to native kwargs

bookmark: migrate `opts` to native kwargs There are a bunch of callers for `ui.formatter()`, so convert to bytes only for that call.

archive: migrate `opts` to native kwargs I'm not sure how to handle migrating core APIs like `scmutil.match`, so kick that can down the road. (Plus it's used all over, so the callers need to be migrated first.)

backout: migrate `opts` to native kwargs It will take a bit to unwind `cmdutil.commit`, so there's a conversion to byteskwargs there, without changing the type of `opts` in this function. That's also useful to flag it as needing to be changed.

cmdutil: migrate `opts` on commitstatus() to native kwargs

cat: avoid round tripping **opts -> byteskwargs -> strkwargs Some internal users still want byteskwargs, so they are serviced in place. Once this pattern of changing types is eliminated everywhere, the remaining internal uses can be cleaned up individually (hopefully).

branching: merge stable into default

transaction: actually delete file created during the transaction on rollback Transaction currently has two modes: - one where file created during the transaction are deleted on rollback, - one where file created during the transaction are truncated to 0 on rollback. Before this change, `hg rollback` and `hg recover` are using the "delete" mode and transaction abort is using the "truncate" option. This difference is never really explained. A long time ago, there was two code paths, with this divergence existing for unclear reasons. When the two code paths got merged into a single one, a boolean argument have been added to preserve this divergence, mostly probably as a cargo cult. The divergence is weird and induce bad surprises, and the truncate behavior is a bit odds, introducing other bad surprises (e.g. 08ecbdba186f) So solve this, we stop using the "truncate" behavior and unify on the "delete" behavior. Despite being currently more "common", the truncate behavior seems less natural, resulting in the transaction leaving empty file around. This is landed on default, early in the cycle, to help us catch problems that could emerge.

rhg: tweak rhg fallback code structure The goal here is to share the code that accesses the config setting, but also move it to the top-level, so that we can more easily change this code later. (in fact in Jane Street we want to make it choose chg in some cases)

journal: track bookmark deletion Bookmark deletion are now properly tracked by the journal extensions.

journal: show that we do not track deletion This was an oversight for the initial implementation.

contrib: upgrade merge-lists from clap v3 to clap v4 Mostly to avoid having clap v3 in our dependencies, due to https://osv.dev/vulnerability/GHSA-g98v-hv3f-hcfr (even though that seems pretty harmless).

infinitepush: drop the extension The writing have been on the wall for a long time.

perf: display all timing by default This is much more useful and end up enable it everywhere. I don't think we have strong backward compatibility guarantee for perf.

wrapfunction: deprecated calling "wrapfunction" with bytes This will help us to detect and eradicates legacy calls. This is on the path to deprecating `util.safehasattr`.

wrapfunction: deprecates calling `wrappedfunction` with bytes This will help us to detect and eradicates legacy calls. This is on the path to deprecating `util.safehasattr`.

wrapfunction: use sysstr instead of bytes as argument in various tests This is as valid and simpler, it will help us to eventually get ride of `safehasattr`.

wrapfunction: use sysstr instead of bytes as argument in "exthelper" This is as valid and simpler, it will help us to eventually get ride of `safehasattr`.

wrapfunction: use sysstr instead of bytes as argument in "sqlitestore" This is as valid and simpler, it will help us to eventually get ride of `safehasattr`.

wrapfunction: use sysstr instead of bytes as argument in "share" This is as valid and simpler, it will help us to eventually get ride of `safehasattr`.

wrapfunction: use sysstr instead of bytes as argument in "perf" This is as valid and simpler, it will help us to eventually get ride of `safehasattr`.

wrapfunction: use sysstr instead of bytes as argument in "zeroconf" This is as valid and simpler, it will help us to eventually get ride of `safehasattr`.

wrapfunction: use sysstr instead of bytes as argument in "sqlitestore" This is as valid and simpler, it will help us to eventually get ride of `safehasattr`.

wrapfunction: use sysstr instead of bytes as argument in "sparse" This is as valid and simpler, it will help us to eventually get ride of `safehasattr`.

wrapfunction: use sysstr instead of bytes as argument in "schemes" This is as valid and simpler, it will help us to eventually get ride of `safehasattr`.

wrapfunction: use sysstr instead of bytes as argument in "remotenames" This is as valid and simpler, it will help us to eventually get ride of `safehasattr`.

wrapfunction: use sysstr instead of bytes as argument in "remotefilelog" This is as valid and simpler, it will help us to eventually get ride of `safehasattr`.

wrapfunction: use sysstr instead of bytes as argument in "pager" This is as valid and simpler, it will help us to eventually get ride of `safehasattr`.

wrapfunction: use sysstr instead of bytes as argument in "narrow" This is as valid and simpler, it will help us to eventually get ride of `safehasattr`.

wrapfunction: use sysstr instead of bytes as argument in "lfs" This is as valid and simpler, it will help us to eventually get ride of `safehasattr`.

wrapfunction: use sysstr instead of bytes as argument in "largefiles" This is as valid and simpler, it will help us to eventually get ride of `safehasattr`.

wrapfunction: use sysstr instead of bytes as argument in "keyword" This is as valid and simpler, it will help us to eventually get ride of `safehasattr`.

wrapfunction: use sysstr instead of bytes as argument in "journal" This is as valid and simpler, it will help us to eventually get ride of `safehasattr`.

wrapfunction: use sysstr instead of bytes as argument in "infinitepush" This is as valid and simpler, it will help us to eventually get ride of `safehasattr`.