check-code: disallow use of hasattr() The hasattr() builtin from Python < 3.2 [1] has slightly surprising behavior: it catches all exceptions, even KeyboardInterrupt. This causes it to have several surprising side effects, such as hiding warnings that occur during attribute load and causing mysterious failure modes when ^Cing an application. In later versions of Python 2.x [0], exception classes which do not inherit from Exception (such as SystemExit and KeyboardInterrupt) are not caught, but other types of exceptions may still silently cause returning False instead of getting a reasonable exception. [0] http://bugs.python.org/issue2196 [1] http://docs.python.org/dev/whatsnew/3.2.html

demandimport: use getattr instead of hasattr We don't use util.safehasattr() here to avoid adding new dependencies for demandimport. This change may expose previously-silenced deprecation warnings to appear, as hasattr silently hides warnings that occur during module import when using demandimport.

demandimport: blacklist rfc822 and mimetools to prevent spurious warnings

i18n: use getattr instead of hasattr Using getattr instead of util.safehasattr here to avoid adding another dependency for i18n.

win32/hgwebdir_wsgi: use getattr instead of hasattr

setup.py: use getattr instead of hasdattr

setup3k: use getattr instead of hasattr Note that hasattr is fixed on Python 3, so this is more about being concise and keeping check-code happy than actual correctness of code.

tests: use getattr instead of hasattr

wireproto: use safehasattr or getattr instead of hasattr

windows: use getattr instead of hasattr

util: use safehasattr or getattr instead of hasattr

templatefilters: use safehasattr instead of hasattr

patch: use safehasattr instead of hasattr

mail: use safehasattr instead of hasattr

url: replace uses of hasattr with safehasattr or getattr

subrepo: use safehasattr instead of hasattr Some of these instances could be rewritten as clever getattr(x, y, default) ladders, but that felt like it impeded readability too much to be worth the modest efficiency gain.

statichttprepo: replace hasattr with getattr

walkrepos: use getattr instead of hasattr for samestat

revlog: use getattr instead of hasattr

lsprof: use getattr instead of hasattr

keepalive: use safehasattr instead of hasattr

hgweb: move remaining hasattr calls to safehasattr

wsgicgi: use getattr instead of hasattr

httprepo: use getattr instead of hasattr