Pierre-Yves David <pierre-yves.david@fb.com> [Thu, 15 Oct 2015 03:13:14 +0100] rev 26727
destmerge: extract logic based on bookmark into its own function
One of the main goal of having consolidated destination function is to allow
extension to play with this logic. We extract sub logic to make is wrapping more
practical.
Pierre-Yves David <pierre-yves.david@fb.com> [Thu, 15 Oct 2015 03:00:09 +0100] rev 26726
destupdate: have a generic and extensible way to run each step
We want extension to be able to easily override or add new way to select the
default update destination. We use the same list + dict approach as in other
parts of the code.
Pierre-Yves David <pierre-yves.david@fb.com> [Thu, 15 Oct 2015 02:33:09 +0100] rev 26725
destupdate: extract logic based on branch in its own function
One of the main goal of having consolidated destination function is to allow
extension to play with this logic. We extract sub logic to make is wrapping more
practical.
Pierre-Yves David <pierre-yves.david@fb.com> [Thu, 15 Oct 2015 02:27:30 +0100] rev 26724
destupdate: extract logic based on bookmarks in its own function
One of the main goal of having consolidated destination function is to allow
extension to play with this logic. We extract sub logic to make is wrapping more
practical.
Pierre-Yves David <pierre-yves.david@fb.com> [Thu, 15 Oct 2015 02:15:43 +0100] rev 26723
destupdate: extract logic based on obsolescence marker in its own function
One of the main goal of having consolidated destination function is to allow
extension to play with this logic. We extract sub logic to make is wrapping more
practical.
Pierre-Yves David <pierre-yves.david@fb.com> [Thu, 15 Oct 2015 02:12:55 +0100] rev 26722
destupdate: move obsolete handling first
This block was overwriting any result from the previous block anyway. So we move
it first to prove it is possible and we'll extract it in its own function in the
next patch.
Pierre-Yves David <pierre-yves.david@fb.com> [Thu, 15 Oct 2015 02:12:15 +0100] rev 26721
destupdate: indent bookmark and branch logic
We'll move the obsolete related logic first (as it is overwriting any other
anyway) to make the next patch clearer we add indentation in this one.
Pierre-Yves David <pierre-yves.david@fb.com> [Thu, 15 Oct 2015 14:10:57 +0100] rev 26720
destupdate: extract validation logic
One of the main goal of having consolidated destination function is to allow
extension to play with this logic. We extract sub logic to make is wrapping more
practical.
Pierre-Yves David <pierre-yves.david@fb.com> [Thu, 15 Oct 2015 01:56:03 +0100] rev 26719
rebase: rename and test '_destrebase'
We make the name consistent with the other similar revsets and make sure it has
minimal tests.
Pierre-Yves David <pierre-yves.david@fb.com> [Thu, 15 Oct 2015 01:51:53 +0100] rev 26718
rebase: directly use '_destrebase'
There is little value in using the revset instead of the function.