cmdutil: fix errors reported by pyflakes test

merge with stable

check-code: complain about set.isdisjoint

fix bookmarks rollback behavior Before this patch undo.bookmarks was created on bookmarks write and not with other transaction-related files. There were two issues: first is that if you have changed bookmarks few times after a transaction happened, rollback will give you a state which can point to non-existing revision. Second is that if you have not changed bookmarks after a transaction, rollback will touch your state anyway. This change also adds `localrepo._writejournal` method, which can be used by other extensions to save their transaction-related backup in right time.

add positional arguments to non-shell aliases

run-tests: take the basepath when constructing the test temp dir so it's possible to run tests that are outside the test/ dir

run-tests: compare absolute paths in _checkhglib

util: rename _windows_reserved_filenames and _windows_reserved_chars

opener: rename _can_symlink to _cansymlink

patch: make patch()/internalpatch() always update the dirstate

patch: move updatedir() from cmdutil into patch Also, create an artificial wdutil.py to avoid import cycles between patch.py and cmdutil.py.

record: unconditionally update the working dir after patching

mq: explicitly updatedir() even if patch() fails It already works that way in practice, and we intend to merge updatedir() into patch().

mq: allow to qpop/push with a dirty working copy (issue2780) It's safe to do so if the sets of changed files in the working copy and patches are disjoint.